Closed Bug 368464 Opened 18 years ago Closed 17 years ago

RSS preview sniffs RSS 0.90 on trunk

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta3

People

(Reporter: sayrer, Assigned: philor)

References

(
URL
)

Details

Attachments

(2 files)

Fix v.1
4.60 KB, patch
sayrer
: review+
beltzner
: approval1.9+
Details | Diff | Splinter Review
as checked in
4.58 KB, patch
Details | Diff | Splinter Review 
We aren't supposed to be sniffing RSS 0.90, and we don't, on the branch. So why is this working on trunk? I went back to 12-02-2006 Minefield 3.0a1, and the trunk was still busted. Investigating.
Assignee: nobody → sayrer
QA Contact: sayrer → rss.preview
You stopped a couple of weeks too soon :)
Assignee: sayrer → philringnalda
Blocks: 345517
OS: Mac OS X → All
Hardware: PC → All
Attached patch Fix v.1 — — Splinter Review 

        Attachment #293815 -
        Flags: review?(sayrer)

    
    

    
  
Comment on attachment 293815 [details] [diff] [review]
Fix v.1

nice

        Attachment #293815 -
        Flags: review?(sayrer) → review+

    
  

        Attachment #293815 -
        Flags: approval1.9?

    
    

    
  
Comment on attachment 293815 [details] [diff] [review]
Fix v.1

a=beltzner for 1.9

        Attachment #293815 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
Blocked on approval in bug 408328, since the patch there creates the directories where I should have put the tests for this bug.
Depends on: 408328

    
    

    
  

      
      
      
      

        Attached patch
          
          
        as checked in
        — 
          — Splinter Review
      

    


  

    
    

    
  
browser/components/feeds/src/nsFeedSniffer.cpp 1.18
browser/components/feeds/test/test_bug368464.html 1.1
browser/components/feeds/test/bug368464-data.xml 1.1
browser/components/feeds/test/Makefile.in 1.2
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: