368509 - Previous/Next and Back/Forward buttons look the same on OSX

Status: RESOLVED DUPLICATE of bug 366842

(Thunderbird :: Mail Window Front End, defect)

Description

[RobertJ]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: version 2 beta 2 (20070116)

In the Customize Window both Previous/Next and Back/Forward buttons are shown (see above url). When dragging them to the toolbar, the Back/Forward buttons don't do anything - only the Previous/Next buttons work as intended. 

Note, both the 

#button-goforward
#button-goback

and

#button-next
#button-previous

id's exist in the TB Mac build in the primaryToolbar.css file and the DOMi shows both nodes. Seems like there is some duplicate code in the Mac build.

Reproducible: Always

Steps to Reproduce:
See above

Comment 1

[Magnus Melin [:mkmelin] (away, back Aug 4)]

I don't know what is should look like on mac, but yes, there should be both Previous/Next and Back/Forward buttons there. Back and Forwards look different (at least on win/linux), but work as general navigation. Previous/Next navigates though unread messages.

Comment 2

[RobertJ]

In that case this IS NOT A BUG. I was confused by the purpose of Back/Forward inasmuch as the icons are identical to Previous/Next. I'm changing it to INVALID although some icon work is needed; not a real big deal.

Comment 3

[RobertJ]

In looking into this further I decided that having duplicate icons doing different  functions is a bug. In addition, I found this in the primaryToolbar.css

/* temporarily re-use the mark button for tags */

Problem is that there is a tag icon in the css file and image regions are different and correct for tag and mark.

#button-tag {
  -moz-image-region: rect(0px 480px 32px 448px);

#button-mark {
  -moz-image-region: rect(0px 448px 32px 416px);
}

I suspect that the comment should have been directed at the Back/Forward buttons. I'm reopening this to insure this goes to whomever is doing the Mac icons and primaryToolbar.css is made aware. Don't know if this is the proper procedure, if not, sorry.

Comment 4

[Mic Wingo]

Both the Back/Forward buttons are  not working properly on TB2b2.  
The back/forward keyboard shortcuts are working fine.
I'm running WinXP sp2.

Comment 5

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Confirming based on screenshot in the URL - updating the summary. 

Mic: works fine over here. And I assume Robert doesn't see it either, based on comment #2. (Try running in -safe-mode.)

Comment 6

[RobertJ]

Magnus is correct; it works for me on Mac. The only issue is icons as noted in Comment #3 and from inspecting the chromes for Linux and Windows it seems like the icon issue is Mac only

Comment 7

[Scott MacGregor]

Kevin is still working on the pinstripe update. We're re-using the prev/next buttons right now. 

Comment 8

[Mic Wingo]

Specifically, when I'm reading my e-mail (in a full window) the Next/Previous icons are shown, but they are for 'unread' items.  The Back/Forward buttons are dimmed, and do not work.  Since they should be for all mail, regardless of whether the items are read, then they should be 'on' at all times.  But they are not.

When I'm reviewing the Inbox window, the Back/Forward buttons are initially dimmed.  Only after I preview items do they come on.  Apparently, they appear to go back and forward to items I previewed only, in the order that I previewed them.  That is not how the Back/Forward keyboard shortcuts work.  The keyboard shortcuts go back/forward to the next email item in the list.  
Again.  I'm not on a Mac, but am on Windows XP sp2.

Comment 9

[David :Bienvenu]

no, the forward/back buttons should only be enabled when there is actually somewhere to go forward/back to. If you've just opened the full message window and read a message, there's nowhere to go forward/back to. If you do a next unread and go to a new message, then back should be enabled, but not forward. If you do a back, then back will be disabled, but forward will be enabled. And so on...

Comment 10

[Mic Wingo]

That doesn't make any sense.  It's quite confusing that the Back/Forward buttons work entirely different from the Back/Forward keyboard shortcuts.  
If they have a different function, they should have a different title.
Also, as they currently work  they are entirely useless to me.  
I would prefer to have buttons that function exactly like the keyboard shortcuts.
That's what I'm used to, and that's how OE works. 
When I review my e-mail,  I need to go forward and backward, regardless of whether I have read the mail.  It's too easy to miss certain items if there is no means to traverse 'all' of them, that is  without individually selecting them.

Comment 11

[David :Bienvenu]

the buttons work exactly like the corresponding keyboard shortcuts. I suspect you're using the next/prev keyboard shortcuts, not the back/forward keyboard shortcuts. I.e., the ones that go to the next/prev messages in the folder order, not the keyboard shortcut for going to the next/prev messages in your navigation history. What you want is toolbar buttons for next/prev message, and you seem to think that's what the back/forward buttons do. It's not. You could file a separate RFE bug to have next/prev buttons that are not Next Unread, prev unread, and not next msg in navigation history, prev message in navigation history.

Comment 12

[Mic Wingo]

The Back/Forward keyboard shortcuts I refer to are 'B' and 'F'.
They are NOT 'N'(Next) and 'P'(Previous), although you can access their function using the Next and Previous menu items within the 'Go' menu.
Again, the Back/Forward keyboard shortcuts do NOT work the same as the new Back/Forward buttons.  On my machine, when I am reading an email and press the 'B' key  Thunderbird delivers the previous e-mail, regardless.  Pressing the 'F' key will show the next message in my mail folder, regardless.
I don't have to concern myself as to whether the item has been read, or not.
Thunderbird 1.5.0.7 and 1.5.0.9 function the same regarding these two shortcuts.
That is why I say the implementation of the new Back/Forward buttons is very confusing, because they do  not  function the same as the  'B'(Back) and 'F'(Forward) keys. 

Comment 13

[David :Bienvenu]

yes, the keyboard shortcut for the back and forward buttons are [ and ]