Update tzids for all tzids in storage.sdb

VERIFIED FIXED in Sunbird 0.5

Status

VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: mattwillis, Assigned: mattwillis)

Tracking

Sunbird 0.3.1
Sunbird 0.5

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Created attachment 253667 [details] [diff] [review]
Upgrades tzids in the db

Since we've updated all the timezones, we should update the ones in storage, rather than try to do so lazily, waiting for each event to be edited.

This does it in SQL.
Flags: blocking-calendar0.3.1+
Attachment #253667 - Flags: first-review?(dmose)
(Assignee)

Updated

12 years ago
Attachment #253667 - Flags: second-review?(dmose)
Attachment #253667 - Flags: first-review?(dmose)
Attachment #253667 - Flags: first-review?(ctalbert.moz)
(Assignee)

Comment 1

12 years ago
After discussion with dmose, we've decided that the gain to 0.3.1 is minimal.  All events will be shown properly due to the tzid conversion code from bug 368724.  They just won't be stored using the 20070129_1 timezones until they are edited in some fashion.

We will want this for 0.5 and future just to get everything cleaned up, since we'll be able to have more testing coverage on this before release with those versions.
Flags: blocking-calendar0.3.1+ → blocking-calendar0.5+
Target Milestone: Sunbird 0.3 → Sunbird 0.5
(Assignee)

Updated

12 years ago
Whiteboard: [patch in hand] [needs review jminta dmose]
(Assignee)

Updated

12 years ago
Whiteboard: [patch in hand] [needs review jminta dmose] → [patch in hand] [needs review ctalbert dmose]
(Assignee)

Comment 2

12 years ago
Created attachment 254297 [details] [diff] [review]
fixes transposed variables

Fixes silly error where variables were transposed.
Attachment #253667 - Attachment is obsolete: true
Attachment #254297 - Flags: second-review?(dmose)
Attachment #254297 - Flags: first-review?(ctalbert.moz)
Attachment #253667 - Flags: second-review?(dmose)
Attachment #253667 - Flags: first-review?(ctalbert.moz)

Comment 3

12 years ago
Comment on attachment 254297 [details] [diff] [review]
fixes transposed variables

This looks good. Tested on Windows, upgrading from version 5 of db(0.3) to 7 (0.4a1 dev build).

Verified by querying sqlite directly.

ctalbert r+
Attachment #254297 - Flags: first-review?(ctalbert.moz) → first-review+
Comment on attachment 254297 [details] [diff] [review]
fixes transposed variables

Looks good; r2=dmose.
Attachment #254297 - Flags: second-review?(dmose) → second-review+
(Assignee)

Comment 5

12 years ago
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Whiteboard: [patch in hand] [needs review ctalbert dmose]
Depends on: 372366

Updated

11 years ago
Status: RESOLVED → VERIFIED
Flags: blocking-calendar0.5+
You need to log in before you can comment on or make changes to this bug.