369834 - Get rid of SetAltDevice and friends

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Eli Friedman]

Attachment: WIP

Pretty straightforward bug; posting with WIP.  There is one semi-blocking issue for this, though: the print preview pages are *way* too big.  I'll figure that out soon and post a real patch for review.

As a side effect, this should fix print preview, which has basically been broken since Thebes landed.

Comment 1

[Eli Friedman]

Attachment: WIP 2

Almost working; still some repainting problems with the scaled print preview, but essentially working.

Unfortunately, it appears that some sort of hinting problem is remaining, because some of the text in the print preview window overlaps.

Comment 2

[Eli Friedman]

Attachment: Finished Patch v1

I'm not really sure of the nsSimplePageSequence changes.  Hopefully, though, that code should go away once we get rid of the current print preview mode.

If we end up needing the PPScale factor for more things, it might be worth naming it something more general.  (One thing we might want it for is scaling up native form controls when printing.)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think instead of this scaling display list item, I'd prefer nsSimplePageSequenceFrame::BuildDisplayList to just build a "pagesequence display item" that's a leaf, and just calls nsLayoutUtils::PaintFrame to paint the children. That way if we need to enhance DisplayListBuilder in the future (e.g. new setup parameters) we won't have to update this code.

PPScale needs a better name, at least call it Get/SetPrintPreviewScale. And add a comment explaining what it does (scales the display, but not layout, of page contents by that amount). Probably should explain why we need both PageScale and PrintPreviewScale -- the former affects layout, the latter does not (right?).

Other than that, this is good.

Comment 4

[Eli Friedman]

Attachment: Patch v2

Okay, updated to comments.  Not quite sure this is what you wanted, but it works.

Comment 5

[Eli Friedman]

Attachment: Patch v2 repost

Oops, that version had a bunch of extra stuff in there accidentally.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Do we need to scale the nsSimplePageSequence's background, border and outline? Does it ever even have one? If not, we can avoid mReentrantPainting by calling nsLayoutUtils::PaintFrame for each child frame.

+  friend void PaintPageSequence(nsIFrame* aFrame, nsIRenderingContext* aCtx,
+                                const nsRect& aDirtyRect, nsPoint aPt);
+  void PaintPageSequence(nsIRenderingContext& aRenderingContext,
+                         const nsRect&        aDirtyRect,
+                         nsPoint              aPt);

Just make PaintPageSequence public, it's easier than this :-).

Comment 7

[Eli Friedman]

Attachment: Patch v3

I guess this works too.  I'm kind of wondering about performance, but I guess it's not a serious issue.

Comment 8

[Eli Friedman]

(In reply to comment #6)
> Do we need to scale the nsSimplePageSequence's background, border and outline?
> Does it ever even have one?

It has a solid gray background, but no border or outline.

Comment 9

[Eli Friedman]

Checked in.