378272 - [UX] Print Preview Scrollbar is too large on No native appearance theme

Status: RESOLVED WORKSFORME

(Core :: Print Preview, defect)

Description

[AKIHIRO Misaki (a.k.a Kuden)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070421 Minefield/3.0a4pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070421

The scrollbar of SeaMonkey Modern theme is broken.
In other words, The scrollbar of no native appearance theme is still broken.
<scrollbar> and <thumb> and <scrollbarbutton> background can not themable on
print preview.

Reproducible: Always

Comment 1

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: Screenshot on SeaMonkey

https://bugzilla.mozilla.org/show_bug.cgi?id=372838#c50

Comment 2

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: Screenshot on Minefield

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070421 Minefield/3.0a4pre
+ Phoenity Modern 0.7.07.04.19
This theme is 90% clone of the SeaMonkey Modern theme.

Comment 3

[Martijn Wargers (dead)]

When did this regress?
Did it used to work in yesterday's build?

Comment 4

[AKIHIRO Misaki (a.k.a Kuden)]

(In reply to comment #3)
> When did this regress?
> Did it used to work in yesterday's build?

no.
Scrollbar looks big is maybe after landed Units Patch (Bug 177805).
<scrollbar> and <thumb> and <scrollbarbutton> background (background-color and background-image) can not themable on print preview is maybe begin at landed cairo.

Comment 5

[Martijn Wargers (dead)]

(In reply to comment #4)
> Scrollbar looks big is maybe after landed Units Patch (Bug 177805).

Could you check that by testing in builds before and after that patch has landed? Thanks.
http://archive.mozilla.org/pub/seamonkey/nightly/2007-02-06-09-trunk/
http://archive.mozilla.org/pub/seamonkey/nightly/2007-02-07-09-trunk/
http://archive.mozilla.org/pub/seamonkey/nightly/

Comment 6

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: {Build ID: 2007020609} ~ {Build ID: 2007020709}

(In reply to comment #5)

SeaMonkey trunk {Build ID: 2007042012} is broken.
{Build ID: 2007020609} and {Build ID: 2007020709} -> fine

When did the display big?

Comment 7

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: {Build ID: 2007021310} ~ {Build ID: 2007021408}

http://bonsai.mozilla.org/cvsquery.cgi?branch=HEAD&date=explicit&mindate=2007-02-13&maxdate=2007-02-14

regress Bug 369834?

Comment 8

[Martijn Wargers (dead)]

(In reply to comment #7)
> regress Bug 369834?

Yeah, I guess that would make sense. Thanks for finding the regression range.
I haven't actually checked it myself, but I'm marking this NEW, based on your screenshots.

Comment 9

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: testcase (userContent.css code for Winstripe)

Please, add the following code to your userContent.css file.
And, show the print preview.

Comment 10

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: screenshot use attachment (id=262396)

Firefox 2 -> print preview scrollbar themable.
trunk -> background-color and background-image not reflected.

Themer has no way of style for the print preview scrollbar.

Comment 11

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: screenshot

I found this cause. 

If the check is not applied to 'Print Background(colors&images)' of 'Page Setup...', background-image of Theme and background-color of Theme are not reflected.

Comment 12

[Peter Weilbacher]

Is this related to bug 345609?

Comment 13

[Alfred Kayser]

This is not just the background that goes wrong.
The size of the scrollbar is also messed up (see screenshots).
It seems to be happening for all themes not using -moz-appearance...

Comment 14

[Ed Hume]

How does one go about nominating this bug to block Firefox 3?

Comment 15

[Alfred Kayser]

Asking for 'blocking1.9' as this is a serious regression from FF2.

Comment 16

[Alfred Kayser]

The issue may be very much in the same direction as in bug 345609.
That in the print-preview display, the non-native scrollbars get some scaling applied that just like the suppression of background-color should not happen.

Comment 17

[[e-mail]]

(In reply to comment #16)
>The issue may be very much in the same direction as in bug 345609.
>That in the print-preview display, the non-native scrollbars get some scaling
>applied that just like the suppression of background-color should not happen.
While the patch for that bug fixes the background colour it doesn't fix the size :-(

Comment 18

[Boris Zbarsky [:bzbarsky]]

We need separate bugs here for Windows and Linux.  On Linux, I get too-small scrollbars, not too-large, and I'm pretty sure it has different causes from the Windows issue.  Someone on Windows should probably step through nsThebesDeviceContext::SetDPI when opening print preview and see what happens.

I filed bug 399671 on the Linux issue.

Comment 19

[Ed Hume]

Request this be marked as a regression.

Comment 20

[DonGato]

I have this issue as well with my theme (just realized). There are any news about it? I think it deserves a regression status.

Comment 21

[DonGato]

Still present in teh recently released Firefox 3.5
Is anybody interested in fixing this?

Comment 22

[Robert Kaiser]

Isn't this related to bug 401213 which is about zoomed pages and non-native themes?

Comment 23

[Alfred Kayser]

Indeed

Comment 24

[Alfred Kayser]

Clearly, this bug doesn't block 369834, as that one is closed, but this problem is not solved.

Comment 25

[Daniel Holbert [:dholbert]]

"blocks" is a somewhat overloaded field -- in this case, it means "this bug was caused by the patch in bug 369834" (aka "this is a regression from bug 369834").

Generally in the future, it's best to look at a bug's history (see 'History' link in upper-right) to see when/why a bug-metadata field was set before you clear the field.  (In this case, the field was set in comment 8)

Comment 26

[Pardal Freudenthal (:ShareBird)]

Any news on this bug?

Comment 27

[Gregory Pappas [:gregp]]

Not an issue anymore.