Open Bug 378272 Opened 13 years ago Updated 2 years ago

[UX] Print Preview Scrollbar is too large on No native appearance theme

Categories

(Core :: Print Preview, defect)

x86
Windows 2000
defect
Not set

Tracking

()

People

(Reporter: spitfire.kuden, Unassigned)

References

(Depends on 1 open bug, )

Details

(Keywords: regression)

Attachments

(6 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070421 Minefield/3.0a4pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070421

The scrollbar of SeaMonkey Modern theme is broken.
In other words, The scrollbar of no native appearance theme is still broken.
<scrollbar> and <thumb> and <scrollbarbutton> background can not themable on
print preview.

Reproducible: Always
Attached image Screenshot on Minefield
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070421 Minefield/3.0a4pre
+ Phoenity Modern 0.7.07.04.19
This theme is 90% clone of the SeaMonkey Modern theme.
When did this regress?
Did it used to work in yesterday's build?
(In reply to comment #3)
> When did this regress?
> Did it used to work in yesterday's build?

no.
Scrollbar looks big is maybe after landed Units Patch (Bug 177805).
<scrollbar> and <thumb> and <scrollbarbutton> background (background-color and background-image) can not themable on print preview is maybe begin at landed cairo.




(In reply to comment #4)
> Scrollbar looks big is maybe after landed Units Patch (Bug 177805).

Could you check that by testing in builds before and after that patch has landed? Thanks.
http://archive.mozilla.org/pub/seamonkey/nightly/2007-02-06-09-trunk/
http://archive.mozilla.org/pub/seamonkey/nightly/2007-02-07-09-trunk/
http://archive.mozilla.org/pub/seamonkey/nightly/
(In reply to comment #5)

SeaMonkey trunk {Build ID: 2007042012} is broken.
{Build ID: 2007020609} and {Build ID: 2007020709} -> fine

When did the display big?
(In reply to comment #7)
> regress Bug 369834?

Yeah, I guess that would make sense. Thanks for finding the regression range.
I haven't actually checked it myself, but I'm marking this NEW, based on your screenshots.
Blocks: 369834
Status: UNCONFIRMED → NEW
Ever confirmed: true
Please, add the following code to your userContent.css file.
And, show the print preview.
Firefox 2 -> print preview scrollbar themable.
trunk -> background-color and background-image not reflected.

Themer has no way of style for the print preview scrollbar.
Attached image screenshot
I found this cause. 

If the check is not applied to 'Print Background(colors&images)' of 'Page Setup...', background-image of Theme and background-color of Theme are not reflected.
Is this related to bug 345609?
This is not just the background that goes wrong.
The size of the scrollbar is also messed up (see screenshots).
It seems to be happening for all themes not using -moz-appearance...
Summary: Print Preview Scrollbar is broken on No native appearance theme → Print Preview Scrollbar is too big on No native appearance theme
Component: GFX: Thebes → Print Preview
Summary: Print Preview Scrollbar is too big on No native appearance theme → Print Preview Scrollbar is too large on No native appearance theme
How does one go about nominating this bug to block Firefox 3?
Asking for 'blocking1.9' as this is a serious regression from FF2.
Flags: blocking1.9?
The issue may be very much in the same direction as in bug 345609.
That in the print-preview display, the non-native scrollbars get some scaling applied that just like the suppression of background-color should not happen.
(In reply to comment #16)
>The issue may be very much in the same direction as in bug 345609.
>That in the print-preview display, the non-native scrollbars get some scaling
>applied that just like the suppression of background-color should not happen.
While the patch for that bug fixes the background colour it doesn't fix the size :-(
We need separate bugs here for Windows and Linux.  On Linux, I get too-small scrollbars, not too-large, and I'm pretty sure it has different causes from the Windows issue.  Someone on Windows should probably step through nsThebesDeviceContext::SetDPI when opening print preview and see what happens.

I filed bug 399671 on the Linux issue.
Flags: wanted1.9+
Flags: blocking1.9?
Flags: blocking1.9-
Request this be marked as a regression.
Keywords: regression
I have this issue as well with my theme (just realized). There are any news about it? I think it deserves a regression status.
Still present in teh recently released Firefox 3.5
Is anybody interested in fixing this?
QA Contact: thebes → printing
Isn't this related to bug 401213 which is about zoomed pages and non-native themes?
Indeed
Clearly, this bug doesn't block 369834, as that one is closed, but this problem is not solved.
No longer blocks: 369834
Depends on: 401213
"blocks" is a somewhat overloaded field -- in this case, it means "this bug was caused by the patch in bug 369834" (aka "this is a regression from bug 369834").

Generally in the future, it's best to look at a bug's history (see 'History' link in upper-right) to see when/why a bug-metadata field was set before you clear the field.  (In this case, the field was set in comment 8)
Blocks: 369834
Any news on this bug?
Summary: Print Preview Scrollbar is too large on No native appearance theme → [UX] Print Preview Scrollbar is too large on No native appearance theme
You need to log in before you can comment on or make changes to this bug.