Closed Bug 369893 Opened 17 years ago Closed 17 years ago

asks to save when it shouldn't since fix for bug 307046

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Keywords: fixed1.8.1.3)

Attachments

(1 file)

proposed fix
2.35 KB, patch
Bienvenu
: review+
mscott
: approval-thunderbird2+
Details | Diff | Splinter Review
Attached patch proposed fix — — Splinter Review 
With the fix for bug 307046, thunderbird asks if I want to save changes in a few situations it shouldn't. 

1) Open a blank mail and don't edit, then try to close
2) Save as Template, then try to close

This patch fixes those cases by keeping track of autosave rather than explicit save.
Attachment #254560 - Flags: review?(bienvenu)
Magnus, what happens with your patch if I open a new compose window, type some stuff in, it auto-saves, and then I close, w/o doing an auto-save? Does it prompt you to save? Does it leave the auto-saved message in the drafts folder?
sorry, I meant without doing an explict save...
It asks to save (since gAutoSaveKickedIn is true) and removes the auto-saved message if I choose not to save in the dialog.
Comment on attachment 254560 [details] [diff] [review]
proposed fix

makes sense, ok, thx!
Attachment #254560 - Flags: review?(bienvenu) → review+
Whiteboard: [checkin needed]
mozilla/mail/components/compose/content/MsgComposeCommands.js  1.108
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Attachment #254560 - Flags: approval-thunderbird2?
Attachment #254560 - Flags: approval-thunderbird2? → approval-thunderbird2+
Whiteboard: [checkin needed (1.8 branch)]
Whiteboard: [checkin needed (1.8 branch)] → fixed1.8.1.3
I landed this on the branch.
Keywords: fixed1.8.1.3
Whiteboard: fixed1.8.1.3
V with TB 2pre-0308.  Unnecessary Save? prompts still occur under some situations, see bug 250965.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: