369935 - Partial feed subscription UI is shown until the feed is loaded

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Asaf Romano (gone)]

With bug 18333 fixed, the "static" part of the feed subscription UI is visible while the feed is being loaded. We should either hide the entire subscription UI until onload is fired or figure out something better I cannot think of at 3:59 AM.

Comment 1

[Asaf Romano (gone)]

Attachment: initialize the subscription UI earlier

Comment 2

[Asaf Romano (gone)]

Attachment: fix comments

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 254691 [details] [diff] [review]
fix comments

>Index: browser/components/feeds/public/nsIFeedWriter.idl

>+  /**
>+   * Writes the feed content, assumes that the feed writer is initialized.
>+   */
>+  void writeContent();

Wouldn't it make sense to make this throw if the writer isn't initialized, and make this an @throws accordingly? Debugging a "feed preview doesn't show up" when writeContent just returns silently isn't really optimal.

Comment 4

[Asaf Romano (gone)]

Filed bug 370018 for that.

Comment 5

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/components/feeds/content/subscribe.js 1.14
mozilla/browser/components/feeds/content/subscribe.xhtml 1.15
mozilla/browser/components/feeds/public/nsIFeedWriter.idl 1.5
mozilla/browser/components/feeds/src/FeedWriter.js 1.36