Closed Bug 369935 Opened 15 years ago Closed 15 years ago

Partial feed subscription UI is shown until the feed is loaded


(Firefox Graveyard :: RSS Discovery and Preview, defect)

Not set


(Not tracked)

Firefox 3 alpha3


(Reporter: mano, Assigned: mano)





(1 file, 2 obsolete files)

With bug 18333 fixed, the "static" part of the feed subscription UI is visible while the feed is being loaded. We should either hide the entire subscription UI until onload is fired or figure out something better I cannot think of at 3:59 AM.
OS: Mac OS X → All
Hardware: Macintosh → All
Summary: Hide the partial feed subscription UI until the feed is loaded → Partial feed subscription UI is shown until the feed is loaded
Attachment #254685 - Flags: review?(sayrer) → review+
Attached patch fix comments (obsolete) — Splinter Review
Attachment #254685 - Attachment is obsolete: true
Attachment #254691 - Flags: review?(
Comment on attachment 254691 [details] [diff] [review]
fix comments

>Index: browser/components/feeds/public/nsIFeedWriter.idl

>+  /**
>+   * Writes the feed content, assumes that the feed writer is initialized.
>+   */
>+  void writeContent();

Wouldn't it make sense to make this throw if the writer isn't initialized, and make this an @throws accordingly? Debugging a "feed preview doesn't show up" when writeContent just returns silently isn't really optimal.
Attachment #254691 - Flags: review?( → review+
Attached patch as checked inSplinter Review
mozilla/browser/components/feeds/content/subscribe.js 1.14
mozilla/browser/components/feeds/content/subscribe.xhtml 1.15
mozilla/browser/components/feeds/public/nsIFeedWriter.idl 1.5
mozilla/browser/components/feeds/src/FeedWriter.js 1.36
Attachment #254691 - Attachment is obsolete: true
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [a3]
Whiteboard: [a3]
Target Milestone: Firefox 3 → Firefox 3 alpha3
Depends on: 411050
No longer depends on: 411050
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.