Closed
Bug 370034
Opened 18 years ago
Closed 18 years ago
Replace nsIDeviceContext::GetDeviceContextFor with nsIDeviceContext::Init
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sharparrow1, Assigned: sharparrow1)
Details
Attachments
(2 files)
|
24.86 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
14.48 KB,
patch
|
Details | Diff | Splinter Review |
GetDeviceContextFor doesn't care about the device it is currently getting called on. Therefore, instead of having to call nsIDeviceContext::GetDeviceContextFor on an existing device context to get a print device context, you should just be able to do_CreateInstance and call Init with an nsIDeviceContextSpec.
I'll make a patch once I've checked in Bug 369834.
|
Assignee | |
Comment 1•18 years ago
|
||
This has a few changes mixed in from Bug 369698; I'll separate them out to check in.
The point of this is to remove the dependency on having a screen device context to print.
Attachment #255082 -
Flags: review?(roc)
Comment on attachment 255082 [details] [diff] [review]
Patch
+ nsCOMPtr<nsIDeviceContext> devctx;
Move this down to where it's assigned.
It would be better if you could separate the patches out for review, just to make the record clear. You'll want to separate them later for checkin anyway...
Attachment #255082 -
Flags: superreview+
Attachment #255082 -
Flags: review?(roc)
Attachment #255082 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
|
|
Assignee | |
Comment 4•18 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•