370135 - Restore branch model history under the trunk History menu.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ria Klaassen (not reading all bugmail)]

Currently, trunk only displays session history under the History (previous Go) menu. 
I think this is a loss of functionality compared with branch, which displays the whole history (although, only 10 items). So please reconsider to restore this function in trunk. The sidebar (By Last Visited) that I have to use instead loads very heavily and a sidebar is not as easy to use even if it loaded quickly. 
And there is already a session history under the Back and Forward dropdown arrows.

Comment 1

[Ria Klaassen (not reading all bugmail)]

This is how I use history normally, and with me a x% of other users:

About 5 times a day I want to go back to an address that I used 3 to 30 items ago. Also if a browser restart has happened in between. The history menu is the most logical first choice. But in trunk, when I am still in the same session I have to search under each and every tab where that address is. I'm not as patient to do that, so I call the history sidebar. But with a places.sqlite file of only a few MBs (= only a few days) I have to wait quite some time before it has loaded when it is set to "By Last Visited" (which of course was the last chosen setting before I closed that sidebar).
I always have to call the sidebar after a restart because the history menu is empty. When this one is set to "By Last Visited" I have no choice but to wait until it has loaded. :(

Comment 2

[(not reading, please use [e-mail] instead)]

over IRC, asaf also mentioned this:

   Mano    ugh, we show session history in places builds?
   Mano    in the history menu
   Mano    rather than global history 

yes, we want to restore fx 2.0 behavior.

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Note bug 365405.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 254847 [details] [diff] [review]
patch

r=sspitzer

asaf, this will be the third place we use this special query (except here you append max results.

maybe we should think about add a special folder id for it?

Comment 5

[Asaf Romano (gone)]

We don't use folder ids for queries so far though.

Comment 6

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-menubar.inc 1.109
mozilla/browser/base/content/browser-places.js 1.29
mozilla/browser/base/content/browser.js 1.762

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv