370216 - make nsIMicrosummaryService use PRInt64 bookmark IDs

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Microsummaries, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

nsIMicrosummaryService currently specifies the data type of bookmark IDs as nsISupports so that the interface can be the same for both RDF-based bookmarks, where IDs are nsIRDFResources, and Places-based bookmarks, where they are currently nsIURIs.

Once Places for bookmarks is enabled by default, by which time Places-based bookmarks will be using PRInt64 IDs, we should change the data type of bookmark IDs in nsIMicrosummaryService to PRInt64 to make it easier to use the interface with Places-based bookmarks.

This bug should depend on a bug about enabling Places-based bookmarks, but I can't find such a bug at the moment.

Comment 1

[Asaf Romano (gone)]

My immediate plan is to pass place: uris to the service rather than bookmark IDs. Otherwise we'll need to wrap integers as nsISupports-primitives and have a very different code path for each bookmarks-implementation in the service code.

I will post the patch for that on bug 370215, this bug will be used for making the service take simple identifiers once support for legacy-bookmarks is dropped.

Comment 2

[Marco Bonardo [:mak]]

- BUGSPAM -
Wontfixing all Microsummaries bugs, since the feature has been removed from the core product and previous versions won't get further fixes for it.
If interested in supporting Microsummaries in your add-on, you're free to use our old microsummaries code and to search all previously open bugs by looking for [microsummaries-feature-removal] in the status whiteboard field.