STEPS TO REPRODUCE 1. add "ac_add_options --enable-perf-metrics" to your .mozconfig 2. build ACTUAL RESULT nsContentSink.cpp:988: error: ‘mWatch’ was not declared in this scope mWatch is used but never declared AFAICT http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/base/src/nsContentSink.cpp&rev=1.60&root=/cvsroot&mark=972,973,979,988,1023#961
I'll start a build once my CPU frees up to see if this does it.
Assignee: xml → jonas
Status: NEW → ASSIGNED
FYI, you'll need this too to find nsTimer.h
Yup, those two patches together builds fine with --enable-perf-metrics. Attaching combined patch for easier review.
Comment on attachment 254972 [details] [diff] [review] that'll do it This patch was checked in (by Jonas) at 2007-02-13 13:18 PST.
Building a clean tree with -enable-perf-metrics still fails though: make: Entering directory `/usr/moz/opt-ff/mozilla/parser/htmlparser/src' make: *** No rule to make target `-lmozutil_s', needed by `libhtmlpars.so'. Stop. make: Leaving directory `/usr/moz/opt-ff/mozilla/parser/htmlparser/src' make: *** [libs] Error 2 make: Leaving directory `/usr/moz/opt-ff/mozilla/parser/htmlparser' make: *** [libs_tier_gecko] Error 2 A regression from bug 78081 perhaps?
This makes my --enable-perf-metrics tree build again. Not sure if this is the correct way of doing it though...
15 years ago
Not a blocker since this is just a testing tool
Flags: blocking1.9? → blocking1.9-
15 years ago
Attachment #256784 - Flags: superreview+ → superreview?(benjamin)
Attachment #256784 - Flags: superreview?(benjamin) → superreview+
Comment on attachment 256784 [details] [diff] [review] More fixes... Checked in to trunk at 2007-03-14 09:44 PST
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.