78081 - Don't export intermediate libraries

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P2)

Description

[cls]

Maintenance bug.  With the landing of the static binary changes, we set
EXPORT_LIBRARY to specify which libs are the ones used in the final link.  It
stands to reason that all other libs are intermediate cruft that do not need to
be symlinked/copied into $(DIST) lest someone think that they are free to use
them.  Unfortunately, we assume that these libs are in $(DIST)/lib when we build
some of the final libraries so their link lines need to change.

Comment 1

[hacker formerly known as [e-mail]]

*** Bug 170975 has been marked as a duplicate of this bug. ***

Comment 2

[cls]

Mass reassign to default build config owner

Comment 3

[(default assignee for unassigned bugs. does not receive bugmail)]

Mass reassign of Build/Config bugs to Leaf.

Comment 4

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 5

[Benjamin Smedberg]

Attachment: Stop shipping static libs by default, rev. 1

This patch requires other treewide work which is not complete yet, so I'm not requesting review yet. It stops shipping static libs by default to dist/lib, and it changes the static build system to look in <objdir>/staticlib instead of dist/lib (so that the libs in dist/lib can be stuff we actually want to ship like xpcomglue etc).

Comment 6

[Benjamin Smedberg]

Attachment: static libs in XPCOM

This patch is an example of what needs to happen treewide (but this patch is just for XPCOM): libs which are intended to become SHARED_LIBRARY_LIBS are not shipped anywhere and are referenced from their tree locations.

I'd like someone to look over the concept and then grant blanket-r to make these kinds of changes treewide.

Comment 7

[Benjamin Smedberg]

Chase/cls/bryner/mento, anyone care to validate or pick at my approach here?

Comment 8

[Mark Mentovai]

Comment on attachment 211181 [details] [diff] [review]
static libs in XPCOM

Have at it!

Comment 9

[Benjamin Smedberg]

Attachment: Fix and document various EXPAND_LIBNAME calls, rev. 1

Comment 10

[Benjamin Smedberg]

Attachment: Move static libs to staticlib/, rev. 1

I still have a few platform-specific fixes to land before this lands, but this is the meaty part of removing intermediate and static libs from dist/lib... intermediate libs aren't installed anywhere: static libs are installed to <objdir>/staticlib

Comment 11

[Mark Mentovai]

...reading...

Comment 12

[Benjamin Smedberg]

Attachment: Move static libs to staticlib/, rev. 2

Comment 13

[Benjamin Smedberg]

Attachment: Move static libs to staticlib/, rev. 2.1

this one build Firefox at least for me on mac, with some changes that I checked in today

Comment 14

[Benjamin Smedberg]

Ted, I haven't updated that patch in a while, so it may need unbitrotting or fixing. If you want to actually test it, I can attach a new one; this one is probably only good for inspection.

Comment 15

[(not currently active) Ted Mielczarek]

I won't have time to give this a good look until probably Monday, so if you can attach a fresh patch by then I'd appreciate it.

Comment 16

[Benjamin Smedberg]

Attachment: Move static libs to staticlib/, rev. 2.2

Un-bitrotted, probably.

I'm doing a full set of builds (three platforms, multiple products, static and nonstatic).

Comment 17

[(not currently active) Ted Mielczarek]

Comment on attachment 253788 [details] [diff] [review]
Move static libs to staticlib/, rev. 2.2

r=me
Looks good, I don't envy the massive search and replace that goes along with this!

Comment 18

[Benjamin Smedberg]

Attachment: Sanify gtkmozembed (again)

Comment 19

[Benjamin Smedberg]

Fixed on trunk!

$ find dist/lib
dist/lib/libasn1.a
dist/lib/libcertdb.a
dist/lib/libcerthi.a
dist/lib/libcrmf.a
dist/lib/libcryptohi.a
dist/lib/libdbm.a
dist/lib/libfreebl.a
dist/lib/libfreebl3.chk
dist/lib/libfreebl3.dylib
dist/lib/libjar.a
dist/lib/libmozjs.dylib
dist/lib/libmozz.a
dist/lib/libnspr4.a
dist/lib/libnspr4.dylib
dist/lib/libnss.a
dist/lib/libnss3.dylib
dist/lib/libnssb.a
dist/lib/libnssckbi.dylib
dist/lib/libnssckfw.a
dist/lib/libnssdev.a
dist/lib/libnsspki.a
dist/lib/libpk11wrap.a
dist/lib/libpkcs12.a
dist/lib/libpkcs7.a
dist/lib/libplc4.a
dist/lib/libplc4.dylib
dist/lib/libplds4.a
dist/lib/libplds4.dylib
dist/lib/libsectool.a
dist/lib/libsecutil.a
dist/lib/libsmime.a
dist/lib/libsmime3.dylib
dist/lib/libsoftokn.a
dist/lib/libsoftokn3.chk
dist/lib/libsoftokn3.dylib
dist/lib/libssl.a
dist/lib/libssl3.dylib
dist/lib/libunicharutil_external_s.a
dist/lib/libunicharutil_s.a
dist/lib/libxpcom.dylib
dist/lib/libxpcom_core.dylib
dist/lib/libxpcomglue.a
dist/lib/libxpcomglue_s.a
dist/lib/libxpistub.dylib
dist/lib/libxpt.a

Not all of these need to be there (I'd argue none of the .dylibs need to be there), but that can be handled separately.

Comment 20

[Boris Zbarsky [:bzbarsky]]

This probably caused bug 372593.