370243 - XULRunner dmg no longer contains installer

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[jhp (no longer active)]

Attachment: patch

Normally, the XULRunner/Mac package is distributed as a disk image that contains an installer.  This seems to have been broken by the fix to bug 359687.  Now, the disk image contains a XULRunner folder which must be manually installed by the user.

Patch is attached.  Gavin, not sure if you are the right person to ask for review during bsmedberg's absence.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 254906 [details] [diff] [review]
patch

Sorry for not mentioning this earlier, but I don't know this code well enough to review it. I believe Benjamin is back from his leave now, though.

Comment 2

[jhp (no longer active)]

Checked in to trunk.  -> FIXED

Comment 3

[jhp (no longer active)]

Comment on attachment 254906 [details] [diff] [review]
patch

Bug 359687 broke this for the two 1.8 branches, so it would be good to fix it there also.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 254906 [details] [diff] [review]
patch

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers

Comment 5

[jhp (no longer active)]

Checked in to both 1.8 branches.