XULRunner dmg no longer contains installer

RESOLVED FIXED

Status

Toolkit Graveyard
XULRunner
RESOLVED FIXED
11 years ago
2 years ago

People

(Reporter: jhp (no longer active), Assigned: jhp (no longer active))

Tracking

({fixed1.8.0.12, fixed1.8.1.4})

Trunk
PowerPC
Mac OS X
fixed1.8.0.12, fixed1.8.1.4

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 254906 [details] [diff] [review]
patch

Normally, the XULRunner/Mac package is distributed as a disk image that contains an installer.  This seems to have been broken by the fix to bug 359687.  Now, the disk image contains a XULRunner folder which must be manually installed by the user.

Patch is attached.  Gavin, not sure if you are the right person to ask for review during bsmedberg's absence.
Attachment #254906 - Flags: first-review?(gavin.sharp)
(Assignee)

Updated

11 years ago
Assignee: nobody → jhpedemonte
Comment on attachment 254906 [details] [diff] [review]
patch

Sorry for not mentioning this earlier, but I don't know this code well enough to review it. I believe Benjamin is back from his leave now, though.
Attachment #254906 - Flags: first-review?(gavin.sharp)
(Assignee)

Updated

11 years ago
Attachment #254906 - Flags: first-review?(benjamin)

Updated

11 years ago
Attachment #254906 - Flags: first-review?(benjamin) → first-review+
(Assignee)

Comment 2

11 years ago
Checked in to trunk.  -> FIXED
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
Comment on attachment 254906 [details] [diff] [review]
patch

Bug 359687 broke this for the two 1.8 branches, so it would be good to fix it there also.
Attachment #254906 - Flags: approval1.8.1.3?
Attachment #254906 - Flags: approval1.8.0.11?
Comment on attachment 254906 [details] [diff] [review]
patch

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #254906 - Flags: approval1.8.1.4?
Attachment #254906 - Flags: approval1.8.1.4+
Attachment #254906 - Flags: approval1.8.0.12?
Attachment #254906 - Flags: approval1.8.0.12+
(Assignee)

Comment 5

11 years ago
Checked in to both 1.8 branches.
Keywords: fixed1.8.0.12, fixed1.8.1.4
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.