370425 - Creating repeating event fails, Error 'calRecurrenceRule is not defined' is shown

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070214 Calendar/0.4a1

Can not press button OK in Edit Recurrence dialog what means that there is no possibility to create or modify repeating events/tasks

Reproducible: Always

Steps to Reproduce:
1. Double press in main view
2. Select checkbox Repeat and press button Set pattern
3. Press OK in Edit Recurrence dialog

Actual Results:  
no effects, dialog is still opened

Expected Results:  
dialog should be closed

error console:

Error: calRecurrenceRule is not defined
Source File: chrome://calendar/content/calendar-recurrence-dialog.js
Line: 235


looks like regression

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed. Looks like regression from Bug 366560. Mismatch between calRecurrenceRule and CalRecurrenceRule?
http://lxr.mozilla.org/mozilla/search?string=calRecurrenceRule

Comment 2

[Joey Minta]

Attachment: patch

Updates calls to the newer calUtils.js

Comment 3

[Matthew (lilmatt) Willis]

Damian,
1. 0.3.1 already shipped. We can't block it anymore :)
2. The bug that caused this wasn't applied to 0.3.1. It's only in the newer builds.

Comment 4

[cmtalbert]

Comment on attachment 255477 [details] [diff] [review]
patch

Looks good.  Tested on Lightning Windows w/tbird 2.0.x.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 255477 [details] [diff] [review]
patch

r2=mvl

Comment 8

[Piglith]

T-bird 1.5.0.10(20070221)
Problem still there in Lightning V0.5pre (build 2007030205).

Setting repeat does nothing.  Unable to click "OK" to execute routine

Comment 9

[Stefan Sitter [:ssitter]]

Please someone take care to check in this regression fix before next Test Day.

Comment 10

[Simon Paquet [:sipaq]]

Fix checked in for trunk and MOZILLA_1_8_BRANCH.

--> FIXED

Comment 11

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3pre) Gecko/20070304 Calendar/0.5pre