370457 - Set RequestExecutionLevel admin in installer and uninstaller

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: patch - requires upgrading NSIS

Though Windows Vista will automatically request elevation for NSIS installers we should explicitly request it in the exe's manifest. This will require upgrading NSIS.

Comment 1

[(not reading, please use [e-mail] instead)]

Comment on attachment 255160 [details] [diff] [review]
patch - requires upgrading NSIS

r=sspitzer, but does this mean we need to ask our buddies in release to upgrade NSIS on the build machines.  And, that would only be for trunk build machines, right?

Comment 2

[(not reading, please use [e-mail] instead)]

this patch looks like something mscott might also need to worry about, for tbird.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #1)
> (From update of attachment 255160 [details] [diff] [review])
> r=sspitzer, but does this mean we need to ask our buddies in release to upgrade
> NSIS on the build machines.  And, that would only be for trunk build machines,
> right?
exactly, and this bug depends on bug 370438 which is to upgrade NSIS.

(In reply to comment #2)
> this patch looks like something mscott might also need to worry about, for
> tbird.
Yes and Sunbird as well. I plan to file the appropriate bugs and provide patches as well.

Comment 4

[Robert Strong (they/them - no direct email)]

btw: upgrading NSIS will not break the other apps if they don't specify this... it has a default value of none and Vista special cases NSIS installers to auto require elevation though I will patch the other apps.

Comment 5

[Robert Strong (they/them - no direct email)]

Fixed by the checkin of Bug 392303.

note: I will be changing this to RequestExecutionLevel user when I fix bug 370571