Closed Bug 370457 Opened 16 years ago Closed 15 years ago

Set RequestExecutionLevel admin in installer and uninstaller

Categories

(Firefox :: Installer, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

Though Windows Vista will automatically request elevation for NSIS installers we should explicitly request it in the exe's manifest. This will require upgrading NSIS.
Attachment #255160 - Flags: review?(sspitzer)
Comment on attachment 255160 [details] [diff] [review]
patch - requires upgrading NSIS

r=sspitzer, but does this mean we need to ask our buddies in release to upgrade NSIS on the build machines.  And, that would only be for trunk build machines, right?
Attachment #255160 - Flags: review?(sspitzer) → review+
this patch looks like something mscott might also need to worry about, for tbird.
(In reply to comment #1)
> (From update of attachment 255160 [details] [diff] [review])
> r=sspitzer, but does this mean we need to ask our buddies in release to upgrade
> NSIS on the build machines.  And, that would only be for trunk build machines,
> right?
exactly, and this bug depends on bug 370438 which is to upgrade NSIS.

(In reply to comment #2)
> this patch looks like something mscott might also need to worry about, for
> tbird.
Yes and Sunbird as well. I plan to file the appropriate bugs and provide patches as well.

btw: upgrading NSIS will not break the other apps if they don't specify this... it has a default value of none and Vista special cases NSIS installers to auto require elevation though I will patch the other apps.
Target Milestone: --- → Firefox 3 M7
Target Milestone: Firefox 3 M7 → Firefox 3 M8
No longer depends on: 370438
Depends on: 384624
Depends on: 392303
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Fixed by the checkin of Bug 392303.

note: I will be changing this to RequestExecutionLevel user when I fix bug 370571
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.