370438 - Upgrade NSIS on the Win32 tinderboxen to version 2.27

Status: RESOLVED DUPLICATE of bug 569534

(Firefox Build System :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

To fix bug 352510 I will need NSIS upgraded to version 2.23 on the trunk.

btw: after version 2.23 is deemed safe I will probably request the 1.8 branch tinderboxen to be upgraded as well.

Comment 1

[Robert Strong (they/them - no direct email)]

Added http://nsis.sourceforge.net/Main_Page to the bug's URL - NSIS can be downloaded from this url

Comment 2

[J. Paul Reed [:preed]]

Reassigning to me, since I'm doing the win32 ref platform upgrade.

Comment 3

[Robert Strong (they/them - no direct email)]

preed, any timeline as to when this will be fixed? I'd like to get the bugs that depend on this fixed well before beta 1

Comment 4

[J. Paul Reed [:preed]]

Probably next week; I'm working on the linux ref platform now (bug 384035, which is to address bug 383960).

Win32 is right behind it.

Comment 5

[Benjamin Smedberg]

Rob, is 2.23 what comes with MozillaBuild? We are planning on using MozillaBuild for the windows refplatform, so if that version is not new enough we'd have to upgrade MozillaBuild.

Comment 6

[Robert Strong (they/them - no direct email)]

It appears that MozillaBuild uses 2.22... I'll check if it is sufficient and post back. Thanks!

Comment 7

[Robert Strong (they/them - no direct email)]

I'm going to verify first but it looks like it has everything needed according to the release notes.

note: after reading the release notes it looks like if we were to upgrade NSIS I would go for at minimum 2.27 but I haven't read the open bugs affecting 2.27 yet.

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to comment #5)
> Rob, is 2.23 what comes with MozillaBuild? We are planning on using
> MozillaBuild for the windows refplatform, so if that version is not new enough
> we'd have to upgrade MozillaBuild.
The version that comes with MozillaBuild has the required features so MozillaBuild is good to go.

Comment 9

[Benjamin Smedberg]

ok, I'm going to make this a Core->BuildConfig bug for the next version of MozillaBuild whenever that comes to pass.

Comment 10

[Robert Strong (they/them - no direct email)]

Changing summary to upgrade to 2.27... please let me know before this happens and I'll check if there is a newer version of NSIS more appropriate to use.

Comment 11

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

The latest NSIS version is now 2.31 FYI.

Comment 12

[Robert Strong (they/them - no direct email)]

Fixed a while ago by multiple bugs with the main bug being bug 569534