370507 - "Disable Add-on" shouldn't be the default action

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Wladimir Palant]

The default action of a form is always the first submit button. Click "Edit author", type something and press Enter in the text field - you will be asked whether you really want to disable the add-on. There are two problems here:

1. "Update" button should come first in the HTML code so that it is the default action.
2. "Add author" should be a separate form so that it doesn't trigger the default action of the page.

Comment 1

[Justin Scott [:fligtar]]

I repositioned all the buttons so that the positive-sounding one is first, however the add author form will take longer and will have to wait awhile.

Comment 2

[Fred Wenzel [:wenzel]]

I added a form tag and made the button a <button> rather than <input>, so that it fires the "add author" javascript event rather than submitting the whole page when you hit enter. (SVN r2644, diff: http://tinyurl.com/24raol)

Is that alright, flig?

Comment 3

[Justin Scott [:fligtar]]

Looks good, thanks Fred.

Did you fix up add_step2.thtml as well?

Comment 4

[Fred Wenzel [:wenzel]]

Now I did. Thanks.