370510 - Extension upload rejects valid extension versions

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Wladimir Palant]

Just got the following message when testing extension upload: "The version of this add-on is invalid: please see the specification". It seems the regular expression used here is /^\d+(\.\d+){0,3}$/ (/app/controllers/components/developers.php). Even the outdated specification cited (Firefox 1.0 version number format) allows to use "+" at the end of the version number, Firefox 1.5 version numbers are far more flexible. The version numbers I use for development builds have the form 0.7.2.4+.2007020523 - perfectly valid.

Comment 1

[Justin Scott [:fligtar]]

The regex is from bug 299479. What pattern would you suggest instead?

Comment 2

[Wladimir Palant]

/^\d+(\+|\w+)?(\.\d+(\+|\w+)?)*$/

Comment 3

[Wladimir Palant]

And current specification is http://developer.mozilla.org/en/docs/Toolkit_version_format

Comment 4

[Justin Scott [:fligtar]]

(In reply to comment #2)
> /^\d+(\+|\w+)?(\.\d+(\+|\w+)?)*$/
> 

shaver: r+?

Comment 5

[Mike Shaver (:shaver emeritus)]

That regex doesn't look like it'd permit

1.5pre4

which is also a valid format according to the doc Wladimir linked.  r=shaver on any regex that passes all the right tests, though! :)

Comment 6

[Mike Shaver (:shaver emeritus)]

RyanJones pointed out that I'm wrong, and it does permit that, so yeah, I guess that's fine!

Comment 7

[Justin Scott [:fligtar]]

Changed regex and updated specification link in r2191

Comment 8

[Wladimir Palant]

Confirmed, works now.

Comment 9

[Dan Stillman]

AMO isn't accepting 1.0.0b4.r5 as a version format due to the version part beginning with a letter instead of a number (".r5"). As far as I can tell from the spec, this should be allowed, since all four parts of the version part are optional (and it installs fine in Firefox).

/^\d+(\+|\w+)?(\.((\d+(\+|\w+)?)|\w+))*$/ would work.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Reopening because problem is back, see comment #9

Comment 11

[Benjamin Smedberg]

Absolutely any string can be parsed as a version, so I suggest you remove the regex altogether

Comment 12

[Justin Scott [:fligtar]]

I think this is somewhere we want to disagree with Firefox. Although any string might be able to be used as a version in Firefox, I'd rather AMO stick with a consistent pattern that is ubiquitous. Having said that, marking FIXED again - I think we should keep the existing regex.

Comment 13

[Mike Shaver (:shaver emeritus)]

Why not warn instead of erroring out?  What is the problem you're trying to protect against?