370595 - Display of localized add-on descriptions broken

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wladimir Palant]

I just tried entering localized information for Adblock Plus - the German and the French versions should have links to the correct versions of the homepage. Default should still be English, it should be a fall-back for both homepage and description. Instead I see that for each language version the displayed information is the same - it is either all English (homepage http://adblockplus.org/en/, English description) or all German (homepage http://adblockplus.org/de/, no add-on name and no description)! When and why it changes between the two I don't know, is there any caching?

Comment 1

[Wladimir Palant]

It is worse than I thought. http://preview.addons.mozilla.org/es-ES/firefox/browse/type:1 shows Adblock Plus as updated but doesn't have a title for it, the search doesn't find it. And Adblock Plus cannot be seen under "Popular Extensions" - not sure whether it is the same bug however.

I copied the English description to the German and French versions to fix the problem there, Spanish (where I didn't enter anything at all) is still broken however.

Comment 2

[Fred Wenzel [:wenzel]]

Wladimir, thanks for pointing this out. The untranslated strings were in fact stored as '' in the translation table and therefore broke translation fallback. I fixed this in SVN r2240. Once preview/production is up to date, you'll be able to save empty strings in the dev cp and they will fall back to the default locale when displayed, then.

Comment 3

[Wladimir Palant]

Sorry, only one part of the problem has been fixed. The "Updated add-ons" list works correctly now. However, add-on information is still cached across locales so that http://preview.addons.mozilla.org/en-US/firefox/addon/1865 and http://preview.addons.mozilla.org/de/firefox/addon/1865 display the same info (check the homepage link, it should be different). Also, when displaying the German info the fallback doesn't work - title and homepage are there (these fields have been entered) but description is missing (that field only exists in English). Finally, http://preview.addons.mozilla.org/es-ES/firefox/search?q=Adblock+Plus&status=4 still doesn't find Adblock Plus - whereas the same search in English does.

Comment 4

[Fred Wenzel [:wenzel]]

Yeah. Fixed in trunk means "not pushed to preview yet". Sorry if that was unclear.

Comment 5

[Wladimir Palant]

I was confused because something definitely *was* pushed to preview. Yes, testing with http://remora.stage.mozilla.com/ now I only see one glitch that is not dependent on locale - probably a different issue.