Closed Bug 370614 Opened 14 years ago Closed 14 years ago

New download URLs make saving extensions difficult

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ecfbugzilla, Assigned: sancus)

References

Details

Go to some extension page, right-click on "Install now" and choose "Save link target as". The suggested file name will be something like 12345.htm - it should be extension_name-version.xpi instead. At the very least it should be done with the Content-Disposition HTTP header.
Content-disposition has no effect on Save Link As, as far as I can tell, so that's pretty useless. However, we will have a "Download" button in place of the install button for Thunderbird add-ons that will use Content-Disposition attachment, and may add one for non-tb add-ons.

The only way I can see to fix this is by tacking the filename onto the end of the url even if it doesn't mean anything to Remora.
Assignee: nobody → sancus
Status: NEW → ASSIGNED
Yes, the content-disposition header might indeed help: http://us2.php.net/header (search for content-disposition). Doesn't this suggest the right filename for the downloaded file?

However if you choose to implement this, make sure it doesn't break the regular installations. :)
(In reply to comment #1)
> Content-disposition has no effect on Save Link As, as far as I can tell, so
> that's pretty useless.

Tested this, you are right.

> The only way I can see to fix this is by tacking the filename onto the end of
> the url even if it doesn't mean anything to Remora.

Exactly.
Re. content disposition headers - Bug 299372
Duplicate of this bug: 371610
I added a trailing filename to all the download urls, which should deal with this.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
V.FIXED on preview.addons.mozilla.org.
Status: RESOLVED → VERIFIED
I'm still seeing this on http://preview.addons.mozilla.org/en-US/thunderbird/addon/878 (login required)
Looks like the sandbox install needs the filename appended as well.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
It has it appended, and works in the test data. Not really sure what's going on here on preview. Going to have to get the full data dump to debug this.
There is a problem with sanitizing the URLs as well, see bug #372302 which fixed +, but other chars, like ' are being left in.

Ciao!
This doesn't seem to be reproducible anymore, does it ?
Yes, I think this can be marked fixed again.
So be it, thanks.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.