guessSystemTimezone() tries to match against old 20050126_1 timezone definition

VERIFIED FIXED in Sunbird 0.5

Status

Calendar
Internal Components
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: Stefan Sitter, Assigned: Joey Minta)

Tracking

({regression})

Trunk
Sunbird 0.5
regression

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.15 KB, patch
Matthew (lilmatt) Willis
: first-review+
Matthew (lilmatt) Willis
: second-review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Bug 366560 moved guessSystemTimezone() from calendarUtils.js to calUtils.js and accidently reverted the changes from Bug 368121.

Now guessSystemTimezone() tries to match against a "/mozilla.org/20050126_1/" timezone string: http://lxr.mozilla.org/mozilla/source/calendar/base/src/calUtils.js#203
(Reporter)

Comment 1

11 years ago
Same applies to update tzid changes calendarDefaultTimezone()
Blocks: 366560
(Assignee)

Comment 2

11 years ago
Created attachment 255479 [details] [diff] [review]
patch

Not a direct port of the patch ssitter cited, but essentially the same.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #255479 - Flags: second-review?(mvl)
Attachment #255479 - Flags: first-review?(lilmatt)
(Reporter)

Comment 3

11 years ago
Comment on attachment 255479 [details] [diff] [review]
patch

> function calendarDefaultTimezone() {

>+        // Update this tzid if necessary.
>+        if (icsSvc.latestTzId(gDefaultTimezone).length) {
>+            gDefaultTimezone = icsSvc.latestTzId(gDefaultTimezone);
>+            prefobj.setCharPref("timezone.local", gDefaultTimezone);
>+        }

Where does prefobj comes from?
(Assignee)

Comment 4

11 years ago
(In reply to comment #3)
Oops, that should be a setPref("calendar.timezone.local", "CHAR", gDefaultTimezone); call.
Comment on attachment 255479 [details] [diff] [review]
patch

r=lilmatt with a XXX comment above the 20070129 line noting that we should centralize where that string comes from.
Attachment #255479 - Flags: first-review?(lilmatt) → first-review+
Comment on attachment 255479 [details] [diff] [review]
patch

r2=mvl
Attachment #255479 - Flags: second-review?(mvl) → second-review+
Whiteboard: [needs checkin]
Created attachment 257362 [details] [diff] [review]
Patch as checked in on MOZILLA_1_8_BRANCH and trunk

Patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED
Attachment #255479 - Attachment is obsolete: true
Attachment #257362 - Flags: second-review+
Attachment #257362 - Flags: first-review+
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: blocking-calendar0.5+
Keywords: regression
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: --- → Sunbird 0.5

Updated

10 years ago
Status: RESOLVED → VERIFIED
Flags: blocking-calendar0.5+
You need to log in before you can comment on or make changes to this bug.