Closed Bug 370670 Opened 13 years ago Closed 13 years ago

guessSystemTimezone() tries to match against old 20050126_1 timezone definition

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Sunbird 0.5

People

(Reporter: ssitter, Assigned: jminta)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Bug 366560 moved guessSystemTimezone() from calendarUtils.js to calUtils.js and accidently reverted the changes from Bug 368121.

Now guessSystemTimezone() tries to match against a "/mozilla.org/20050126_1/" timezone string: http://lxr.mozilla.org/mozilla/source/calendar/base/src/calUtils.js#203
Same applies to update tzid changes calendarDefaultTimezone()
Blocks: 366560
Attached patch patch (obsolete) — Splinter Review
Not a direct port of the patch ssitter cited, but essentially the same.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #255479 - Flags: second-review?(mvl)
Attachment #255479 - Flags: first-review?(lilmatt)
Comment on attachment 255479 [details] [diff] [review]
patch

> function calendarDefaultTimezone() {

>+        // Update this tzid if necessary.
>+        if (icsSvc.latestTzId(gDefaultTimezone).length) {
>+            gDefaultTimezone = icsSvc.latestTzId(gDefaultTimezone);
>+            prefobj.setCharPref("timezone.local", gDefaultTimezone);
>+        }

Where does prefobj comes from?
(In reply to comment #3)
Oops, that should be a setPref("calendar.timezone.local", "CHAR", gDefaultTimezone); call.
Comment on attachment 255479 [details] [diff] [review]
patch

r=lilmatt with a XXX comment above the 20070129 line noting that we should centralize where that string comes from.
Attachment #255479 - Flags: first-review?(lilmatt) → first-review+
Comment on attachment 255479 [details] [diff] [review]
patch

r2=mvl
Attachment #255479 - Flags: second-review?(mvl) → second-review+
Whiteboard: [needs checkin]
Patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED
Attachment #255479 - Attachment is obsolete: true
Attachment #257362 - Flags: second-review+
Attachment #257362 - Flags: first-review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: blocking-calendar0.5+
Keywords: regression
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: --- → Sunbird 0.5
Status: RESOLVED → VERIFIED
Flags: blocking-calendar0.5+
You need to log in before you can comment on or make changes to this bug.