370670 - guessSystemTimezone() tries to match against old 20050126_1 timezone definition

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Bug 366560 moved guessSystemTimezone() from calendarUtils.js to calUtils.js and accidently reverted the changes from Bug 368121.

Now guessSystemTimezone() tries to match against a "/mozilla.org/20050126_1/" timezone string: http://lxr.mozilla.org/mozilla/source/calendar/base/src/calUtils.js#203

Comment 1

[Stefan Sitter [:ssitter]]

Same applies to update tzid changes calendarDefaultTimezone()

Comment 2

[Joey Minta]

Attachment: patch

Not a direct port of the patch ssitter cited, but essentially the same.

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 255479 [details] [diff] [review]
patch

> function calendarDefaultTimezone() {

>+        // Update this tzid if necessary.
>+        if (icsSvc.latestTzId(gDefaultTimezone).length) {
>+            gDefaultTimezone = icsSvc.latestTzId(gDefaultTimezone);
>+            prefobj.setCharPref("timezone.local", gDefaultTimezone);
>+        }

Where does prefobj comes from?

Comment 4

[Joey Minta]

(In reply to comment #3)
Oops, that should be a setPref("calendar.timezone.local", "CHAR", gDefaultTimezone); call.

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 255479 [details] [diff] [review]
patch

r=lilmatt with a XXX comment above the 20070129 line noting that we should centralize where that string comes from.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 255479 [details] [diff] [review]
patch

r2=mvl

Comment 7

[Matthew (lilmatt) Willis]

Attachment: Patch as checked in on MOZILLA_1_8_BRANCH and trunk

Patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED