Closed
Bug 370769
Opened 19 years ago
Closed 18 years ago
All popups overflow
Categories
(Core :: Widget: Cocoa, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha3
People
(Reporter: asaf, Assigned: jaas)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
2.34 KB,
patch
|
cbarrett
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=369584#c3, that's now on trunk as a result of bug 370659.
|
Reporter | |
Comment 1•19 years ago
|
||
|
|
Reporter | |
Updated•19 years ago
|
Priority: -- → P2
Target Milestone: --- → mozilla1.9alpha3
Comment on attachment 255497 [details] [diff] [review]
patch
good for now, thanks
Attachment #255497 -
Flags: review?(joshmoz) → review+
|
|
Reporter | |
Updated•19 years ago
|
Attachment #255497 -
Flags: superreview?(pavlov)
This is probably a better way of doing it. We'll do fewer checks in this method and be more conservative about assigning overflow, which will probably help with layout perf.
Attachment #255497 -
Attachment is obsolete: true
Attachment #255801 -
Flags: review?(cbarrett)
Attachment #255497 -
Flags: superreview?(pavlov)
Attachment #255497 -
Flags: review+ → review-
|
||
Comment 4•18 years ago
|
||
Comment on attachment 255801 [details] [diff] [review]
patch v2.0
r=cbarrett
It's clearer to indicate which controls are drawing focus rects.
Attachment #255801 -
Flags: review?(cbarrett) → review+
landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•18 years ago
|
||
Comment on attachment 255801 [details] [diff] [review]
patch v2.0
rs=pink
Attachment #255801 -
Flags: superreview+
|
|
Reporter | |
Updated•18 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Updated•18 years ago
|
Assignee: mano → joshmoz
Status: REOPENED → NEW
|
|
Reporter | |
Updated•18 years ago
|
Status: NEW → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•