Closed Bug 370891 Opened 15 years ago Closed 15 years ago

compose window fails if myspell is not registered

Categories

(SeaMonkey :: MailNews: Message Display, defect)

1.8 Branch
x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wolfiR, Assigned: neil)

Details

(Keywords: fixed-seamonkey1.1.1)

Attachments

(1 file)

I've updated to 1.1.1 and now I can't compose mails anymore but just get
"An error occurred while creating a message compose window. Please try again."

Turned out that the problem is:
EX: = TypeError: Components.classes['@mozilla.org/spellchecker/myspell;1'] has no properties

I don't have the spellchecker component installed since I build RPMs which are split up and spellchecker is a subpackage which I don't install usually.
That worked always in the past but now fails with SM 1.1.1
Attached patch Proposed patchSplinter Review
Dunno how that crept in...
Assignee: mail → neil
Status: NEW → ASSIGNED
Attachment #255680 - Flags: review?(mnyromyr)
Attachment #255680 - Flags: approval-seamonkey1.1.1?
At least I can compose mails again with that patch. Thanks.
Flags: blocking-seamonkey1.1.1?
Attachment #255680 - Flags: approval-seamonkey1.1.1? → approval-seamonkey1.1.1+
Flags: blocking-seamonkey1.1.1? → blocking-seamonkey1.1.1+
Comment on attachment 255680 [details] [diff] [review]
Proposed patch

Shouldn't we be doing:
if ("@mozilla.org/spellchecker;1" in Components.classes)
within the InitLanguageMenu function too? Does this also need fixing in TB?
Attachment #255680 - Flags: review?(mnyromyr) → review+
(In reply to comment #3)
>(From update of attachment 255680 [details] [diff] [review])
>Shouldn't we be doing:
>if ("@mozilla.org/spellchecker;1" in Components.classes)
>within the InitLanguageMenu function too?
No, because the spelling button will be disabled.

>Does this also need fixing in TB?
Probably. I pinged scott over AIM.
Neil checked this in, I moved the 1.1.1 tag accordingly.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Phil, are you interested in porting this to tbird since you're helping out with Bug 377662?
Yep, I'll get it this weekend, but probably by reusing bug 318030 since it looks like maybe Tb needs some help disabling the UI once you do get in without a dictionary.
You need to log in before you can comment on or make changes to this bug.