370891 - compose window fails if myspell is not registered

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

I've updated to 1.1.1 and now I can't compose mails anymore but just get
"An error occurred while creating a message compose window. Please try again."

Turned out that the problem is:
EX: = TypeError: Components.classes['@mozilla.org/spellchecker/myspell;1'] has no properties

I don't have the spellchecker component installed since I build RPMs which are split up and spellchecker is a subpackage which I don't install usually.
That worked always in the past but now fails with SM 1.1.1

Comment 1

[[e-mail]]

Attachment: Proposed patch

Dunno how that crept in...

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

At least I can compose mails again with that patch. Thanks.

Comment 3

[Ian Neal]

Comment on attachment 255680 [details] [diff] [review]
Proposed patch

Shouldn't we be doing:
if ("@mozilla.org/spellchecker;1" in Components.classes)
within the InitLanguageMenu function too? Does this also need fixing in TB?

Comment 4

[[e-mail]]

(In reply to comment #3)
>(From update of attachment 255680 [details] [diff] [review])
>Shouldn't we be doing:
>if ("@mozilla.org/spellchecker;1" in Components.classes)
>within the InitLanguageMenu function too?
No, because the spelling button will be disabled.

>Does this also need fixing in TB?
Probably. I pinged scott over AIM.

Comment 5

[Robert Kaiser]

Neil checked this in, I moved the 1.1.1 tag accordingly.

Comment 6

[Scott MacGregor]

Phil, are you interested in porting this to tbird since you're helping out with Bug 377662?

Comment 7

[Phil Ringnalda (:philor)]

Yep, I'll get it this weekend, but probably by reusing bug 318030 since it looks like maybe Tb needs some help disabling the UI once you do get in without a dictionary.