371043 - [FIX]Computed style doesn't handle eStyleUnit_Chars well

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 365932 comment 3.

Right now we do:

2745     case eStyleUnit_Chars:
2746       // XXX we need a frame and a rendering context to calculate this, bug 281972, bug 282126.
2747       aValue->SetAppUnits(0);
2748       break;

David points out that all we really need is an nsStyleFont (which computed style knows how to get) and a rendering context; we should be able to get a rendering context from the presshell, right?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

That diff depends on the fix for bug 371041.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 261224 [details] [diff] [review]
Proposed patch

In the reftest, I'd recommend giving the span a few pixels of horizontal padding in case the M's overflow.

r+sr=dbaron (although it would be nice to have a nicer way to make a rendering context)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in, with the padding.

Comment 5

[Armen [:armenzg]]

This reftest is failing for Fedora unit tests (see bug 560882).
I have machines available to help fixing it.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Please don't reopen bugs for that sort of thing.  File new ones.