371724 - Writing to xbl properties marked readonly no longer throws an exception

Status: VERIFIED FIXED

(Core :: XBL, defect)

Description

[:Gijs (out for now; he/him)]

Attachment: Testcase

As in summary. The specific xbl this is about is tabbox.xml: writing to the readonly "selected" property of a tab doesn't seem to throw any errors in the latest nightly:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070225 Minefield/3.0a3pre

Not sure if this is a bug in XBL or in JS.

This worked in the 20070223 Mac build, so it broke somewhere this weekend. I haven't tried to get a smaller regression range yet, but it should be possible.

Comment 1

[Martijn Wargers (dead)]

This regressed between 2007-02-24 and 2007-02-25:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-24+04&maxdate=2007-02-25+06&cvsroot=%2Fcvsroot

Comment 2

[:Gijs (out for now; he/him)]

Maybe bug 369404?

Comment 3

[Martijn Wargers (dead)]

Attachment: mochikit version of Gijs's testcase

I think this Mochikit testcase is correct. However, it doesn't work in current trunk builds, because of bug 371743 (which I found out because of this).
Also depends on getting the test from bug 366770 checked in, first.

Comment 4

[:Gijs (out for now; he/him)]

As noted on that bug, backing out the patch for bug 369404 fixes this one.

Comment 5

[Brendan Eich [:brendan]]

Attachment: d'oh, should have read my own jsscope.h comments more closely

Comment 6

[Brendan Eich [:brendan]]

Fixed on trunk:

js/src/jsobj.c 3.330

/be

Comment 7

[Brendan Eich [:brendan]]

Er, that was rev 3.331, not 3.330.

/be

Comment 8

[:Gijs (out for now; he/him)]

The test passes on my build with this fix. Thanks for the quick fix, Brendan!

I think it'd still be nice to get the mochikit-test in, but I have no idea what would need to happen in order to do that. Martijn, I'm assuming you know more?

Comment 9

[Martijn Wargers (dead)]

Comment on attachment 256460 [details]
mochikit version of Gijs's testcase

I guess the "Success!" in the bound element doesn't make sense.
I have this test in content/xbl/test/.
Like I said, this test depends on bug 371743 and the mochipatch from bug 366770 getting checked in (more or less).

Comment 10

[Robert Sayre]

Comment on attachment 256460 [details]
mochikit version of Gijs's testcase

looks ok, but please check the exception type if there is a detailed one.

Comment 11

[Martijn Wargers (dead)]

Attachment: for check-in as soon as bug 371743 is fixed

Comment 12

[Martijn Wargers (dead)]

Checking in Makefile.in;
/cvsroot/mozilla/content/xbl/test/Makefile.in,v  <--  Makefile.in
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/content/xbl/test/test_bug371724.xhtml,v
done
Checking in test_bug371724.xhtml;
/cvsroot/mozilla/content/xbl/test/test_bug371724.xhtml,v  <--  test_bug371724.xh
tml
initial revision: 1.1
done

Bug 371743 was fixed, so I checked the Mochikit test in.