371743 - [FIX]Script with src attribute causes xbl binding not to get applied in this case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Martijn Wargers (dead)]

Attachment: testcase

I was trying to make a mochikit test for bug 371724 and got severely frustrated, because I couldn't get it working.

See testcase, you should see some text with the testcase, no blank page.
This regressed between 2006-11-02 and 2006-11-04, I think a regression from bug 343730.

I don't see this bug with a 2007-02-07 branch build.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w

Without this, if there's no script global (as for XBL) we block the parser but don't ever load the script... so never get anywhere on the XBL.  And probably leak to boot.

Comment 3

[Robert Sayre]

let's make sure automate this test case

Comment 4

[Martijn Wargers (dead)]

Well, the mochikit testcase would automatically fail if this bug would reoccur, so it does seem to me there is no separate mochitest necessary.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch I landed (updated to tip)

Comment 7

[Martijn Wargers (dead)]

I'm marking this in-testsuite-, because I checked in the Mochikit test for bug 371724, it automatically also checks this bug.
If you want a separate test for this, let me know, I'll be happy to make one.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

If this is tested by an existing test, it should be marked "in-testsuite+". That being said, having a test that tests this bug directly instead of indirectly is probably a good idea, if it's not too much work.