Closed
Bug 371774
Opened 18 years ago
Closed 18 years ago
process_bug.cgi should only validate longdesclength on mid-air collision
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
1.12 KB,
patch
|
wicked
:
review+
|
Details | Diff | Splinter Review |
Currently, process_bug.cgi checks that longdesclength is defined in all cases, despite it's only used on mid-air collision. This check should only be done when checking if a mid-air collision is occuring, see line 255:
if (defined $cgi->param('delta_ts') && $cgi->param('delta_ts') ne $delta_ts)
{
$vars->{'title_tag'} = "mid_air";
}
This would avoid useless error messages.
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #257990 -
Flags: review?(wicked+bz)
|
||
Updated•18 years ago
|
Attachment #257990 -
Flags: review?(wicked+bz) → review+
|
|
||
Updated•18 years ago
|
Flags: approval?
|
|
Assignee | |
Updated•18 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi
new revision: 1.356; previous revision: 1.355
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•