371779 - Reevaluate required fields for user profiles

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Wil Clouser [:clouserw]]

I've had people ask me on IRC to remove the "Last name must not be empty" requirement (and I agree it should go).  We used to require nicknames - maybe we could bring that back and remove lastname, or..?

Our current requirements are:

        'email'     => VALID_EMAIL,
        'password'  => VALID_NOT_EMPTY,
        'firstname' => VALID_NOT_EMPTY,
        'lastname'  => VALID_NOT_EMPTY,
        'homepage'  => VALID_URL_OPT

Comment 1

[Wladimir Palant]

I do not use nicknames and I think I am not alone with it. Would it be possible to require at least one of firstname/lastname/nickname to be filled in?

Comment 2

[Cameron]

Why do we even have more than one name field? Maybe "Nickname" and "Real name" (real name being optional and used for stuff like official communication or sending tshirts...)

Comment 4

[Fred Wenzel [:wenzel]]

We'll change this requirement to Nickname OR First+Last.

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Require either (first and last) or (nickname)

This patch enforces our new "required fields" policy (that is, first and last OR nick) on a model level, and add a little explanation to the register and edit views as well.

Comment 6

[Wil Clouser [:clouserw]]

The patch works fine, but why are we requiring both first name and last name?  Why can't it just be first or last or nickname?

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #6)
> The patch works fine, but why are we requiring both first name and last name? 

Hm, dunno, wasn't that what we decided on? I guess it makes sense though. We just don't want the entire thing to be empty.

I'll make a new patch.

Comment 8

[Fred Wenzel [:wenzel]]

On the other hand: We require the nickname to be unique, but not the other fields. So if someone's nickname was "clouserw", everybody else could fill that into the firstname box and imitate him. What do you say?

Comment 9

[Wil Clouser [:clouserw]]

(In reply to comment #8)
> On the other hand: We require the nickname to be unique, but not the other
> fields. So if someone's nickname was "clouserw", everybody else could fill that
> into the firstname box and imitate him. What do you say?

I don't think that's a problem we're going to solve here.  Whether someone makes their name ". clouserw" or "c1ouserw" (that's a one right thar) there are just too many combinations of similar looking names.

Comment 10

[Fred Wenzel [:wenzel]]

Attachment: Require any of the three name fields not to be empty

This patch just enforces one of the three fields not to be empty.

Comment 11

[Fred Wenzel [:wenzel]]

Thanks: Committed to r19440, l10n in r19441.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/users/register