371814 - undo-ing an item move in the organizer fails

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

*** == UNMove Items (UNAggregate) ============
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "MIN_TRANSACTIONS_FOR_BATCH is not defined" {file: "chrome://browser/content/places/controller.js" line: 1521}]' when calling method: [nsITransaction::undoTransaction]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/places/controller.js :: PC_doCommand :: line 300"  data: yes]
************************************************************

Comment 1

[Asaf Romano (gone)]

global scope with transactions is a mess :-/

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 257596 [details] [diff] [review]
patch

will any other of the constants declared in controller.js have this same problem? if so, please file a follow-up bug for addressing that.

Comment 4

[Asaf Romano (gone)]

We don't use any of them in transactions as far as I can tell.

Comment 5

[Asaf Romano (gone)]

mozilla/browser/components/places/content/controller.js 1.132

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091411 Minefield/3.0a8pre ID:2007091411

This appears to be hopelessly broken tested on new profile)

repro:
open Organise bookmarks
Go into a folder
drag a bookmark a few places up or down
press ctrl+Z

result:
nothing happens
Menu [Edit]->[Undo] and [redo] are grayed out

move a few more bookmarks
Menu [Edit]->[Undo] and [redo] may not be grayed out any longer
Redo and/or Undo may become acc. after a move bookmark but often don't work (no response).

No messages in the errorconsole

Comment 7

[Peter van der Woude [:Peter6]]

I'm not sure if this bug should be closed and Bug 390739 should be used instead

Comment 8

[Dietrich Ayala (:dietrich)]

(In reply to comment #7)
> I'm not sure if this bug should be closed and Bug 390739 should be used instead
> 

That bug is fixed, are you still seeing the problems?

Comment 9

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007121009 Minefield/3.0b2pre ID:2007121009
FIXED

Comment 10

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre)
Gecko/2007121805 Minefield/3.0b3pre and the equivalent Mac nightly build. 

Comment 11

[Tracy Walker [:tracy]]

Litmus test case added for undo/redo of Moved items.

https://litmus.mozilla.org/show_test.cgi?id=5142

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv