372236 - Internet Shortcut (.url) icons are now icons of Firefox instead of a page with a Firefox icon on it

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Charlie Hayes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070206 Minefield/3.0a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070206 Minefield/3.0a2pre

The default icons used for shortcuts are not documents any more, they are the actual firefox icon.

Reproducible: Always

Steps to Reproduce:
1. Let firefox set itself as default browser
2.
3.
Actual Results:  
Icons change to big firefox logo

Expected Results:  
Icons stay as or change to piece of paper with smaller firefox logo stamped on it

This is a reversion that has happened in a recent build. It is still in firefox 2.0.2 and the latest nightly as of this bug's creation

Comment 1

[Charlie Hayes]

the registry key:
HKEY_CLASSES_ROOT\HTTP\DefaultIcon

has a default value of:
C:\Program Files\Minefield\firefox.exe,0

should be:
C:\Program Files\Minefield\firefox.exe,1

Comment 2

[Thomas Bertels]

Bug 354005 seems to be culprit.

Comment 3

[Thomas Bertels]

Attachment: Restore the good icon - branch

Comment 4

[Thomas Bertels]

Attachment: Restore the good icon - trunk

Comment 5

[Thomas Bertels]

I suspect that the FirefoxURL\DefaultIcon has also to be set to 1 instead of 0, but since this is Vista related, I can't test it.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 257120 [details] [diff] [review]
Restore the good icon - branch

The installer will also need to be patched in several places.
http://lxr.mozilla.org/seamonkey/source/browser/installer/windows/nsis/shared.nsh#372

Comment 7

[Thomas Bertels]

Attachment: Restore the good icon 2 - branch

I also changed the comment about the Vista regkey, since VAL_URL_ICON is used for both XP and Vista, which I didn't notice the first time.

Comment 8

[Thomas Bertels]

Attachment: Restore the good icon 2 - trunk

Comment 9

[Mike Connor [:mconnor]]

not critical enough to take for 1.8.1.3, should take for 1.8.1.4 for sure.

Comment 10

[David Leben]

Just FYI, I have the same problem in Windows XP SP2 with Firefox 2.0.0.2.

When I change the icon manually using Windows' Folder Options -> File Types -> [select different URL file types] -> Advanced -> Change Icon, the next time I start Firefox it complains it is not the default browser anymore. If I click Yes in this dialog, the document icons are switched back to the wrong icon, the Firefox application icon.

Comment 12

[Robert Strong (they/them - no direct email)]

Thomas, there are several other places in shared.nsi that set the DefaultIcon... did you check if those need to be changed as well?

Comment 13

[Thomas Bertels]

(In reply to comment #12)
Do you mean shared.nsh ? If so, those lines don't change the icon for .url files.
Anyway, it can't become worse than now, but it would be even better to be able to test it on the trunk.

Comment 14

[Robert Strong (they/them - no direct email)]

Correct... shared.nsh

Please take another look in shared.nsh... for example you fix it for one place the DefaultIcon is set for FirefoxURL but not in the other place where it is set:
http://lxr.mozilla.org/seamonkey/source/browser/installer/windows/nsis/shared.nsh#372
and
http://lxr.mozilla.org/seamonkey/source/browser/installer/windows/nsis/shared.nsh#152

Comment 15

[Thomas Bertels]

Attachment: Restore the good icon 3 - branch

You're right, there were still some things to change for FirefoxURL and the protocols, I didn't see them.

Comment 16

[Thomas Bertels]

Attachment: Restore the good icon 3 - trunk

Comment 17

[Daniel Veditz [:dveditz]]

Comment on attachment 262045 [details] [diff] [review]
Restore the good icon 3 - branch

Please wait until you've got reviews to request branch-landing approval. This bug is at risk of not making this release.

Comment 18

[Robert Strong (they/them - no direct email)]

Comment on attachment 262046 [details] [diff] [review]
Restore the good icon 3 - trunk

>Index: components/shell/src/nsWindowsShellService.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/browser/components/shell/src/nsWindowsShellService.cpp,v
>retrieving revision 1.44
>diff -u -r1.44 nsWindowsShellService.cpp
>--- components/shell/src/nsWindowsShellService.cpp	23 Mar 2007 21:32:30 -0000	1.44
>+++ components/shell/src/nsWindowsShellService.cpp	18 Apr 2007 22:26:23 -0000
>@@ -162,7 +162,7 @@
> //   HKCU\SOFTWARE\Classes\FirefoxURL\  (default)         REG_SZ     <appname> URL
> //                                      EditFlags         REG_DWORD  2
> //                                      FriendlyTypeName  REG_SZ     <appname> URL
>-//     DefaultIcon                      (default)         REG_SZ     <apppath>,0
>+//     DefaultIcon                      (default)         REG_SZ     <apppath>,1
> //     shell\open\command               (default)         REG_SZ     <apppath> -url "%1" -requestPending
> //     shell\open\ddeexec               (default)         REG_SZ     "%1",,0,0,,,,
> //     shell\open\ddeexec               NoActivateHandler REG_SZ
>@@ -176,7 +176,7 @@
> //   are mapped like so:
> //
> //   HKCU\SOFTWARE\Classes\<protocol>\
>-//     DefaultIcon                      (default)         REG_SZ     <apppath>,0
>+//     DefaultIcon                      (default)         REG_SZ     <apppath>,1
> //     shell\open\command               (default)         REG_SZ     <apppath> -url "%1" -requestPending
> //     shell\open\ddeexec               (default)         REG_SZ     "%1",,0,0,,,,
> //     shell\open\ddeexec               NoActivateHandler REG_SZ
>@@ -231,7 +231,7 @@
> 
> #define CLS_HTML "FirefoxHTML"
> #define CLS_URL "FirefoxURL"
>-#define VAL_URL_ICON "%APPPATH%,0"
>+#define VAL_URL_ICON "%APPPATH%,1"
> #define VAL_FILE_ICON "%APPPATH%,1"
> #define VAL_OPEN "\"%APPPATH%\" -url \"%1\" -requestPending"
> 
Just remove VAL_URL_ICON and use VAL_FILE_ICON for all its occurences

with that r=me

Comment 19

[Robert Strong (they/them - no direct email)]

Comment on attachment 262045 [details] [diff] [review]
Restore the good icon 3 - branch

Resubmit this with the same changes as requested for the trunk patch and I'll r+ it. I want to see it first before +'ing it since this will go on the branch

Comment 20

[Daniel Veditz [:dveditz]]

Comment on attachment 262045 [details] [diff] [review]
Restore the good icon 3 - branch

robert wants a new patch

Comment 21

[Thomas Bertels]

Attachment: Restore the good icon 4 - branch

Comment 22

[Robert Strong (they/them - no direct email)]

Comment on attachment 262686 [details] [diff] [review]
Restore the good icon 4 - branch

Looks good and thanks!

Comment 23

[Thomas Bertels]

Attachment: Restore the good icon 4 - trunk

It seems I was very tired yesterday, I thought I added a comment, but don't know what happened. Anyway, here are the good patches.

Comment 24

[Thomas Bertels]

Comment on attachment 262686 [details] [diff] [review]
Restore the good icon 4 - branch

I wonder if there are still chances for it to make this release.

Comment 25

[Robert Strong (they/them - no direct email)]

Comment on attachment 262687 [details] [diff] [review]
Restore the good icon 4 - trunk

I'll get this checked in

Comment 26

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 27

[Daniel Veditz [:dveditz]]

Comment on attachment 262686 [details] [diff] [review]
Restore the good icon 4 - branch

approved for 1.8.1.4, a=dveditz for release-drivers

Comment 28

[Robert Strong (they/them - no direct email)]

Thomas, I'll get this checked in today.

Comment 29

[Thomas Bertels]

Thank you, Robert.
I tested the last trunk build and it works nicely, I was thinking that Firefox would ask to be set as default, but it doesn't.

Comment 30

[Robert Strong (they/them - no direct email)]

If we are already default we automatically fix the key on install or on software update. Also, the reg key is no longer checked per bug 375114

Comment 31

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH for Firefox 2.0.0.4

Comment 32

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.4 using RC 1 of 2004 Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4) Gecko/2007050106 Firefox/2.0.0.4 - the page have now a Firefox icon on it. Adding verified keyword