After MS Office is updated the user is prompted to set Firefox as the default browser even though it already is the default browser

RESOLVED FIXED

Status

()

Firefox
Shell Integration
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

({verified1.8.1.4})

2.0 Branch
x86
Windows Vista
verified1.8.1.4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Created attachment 259429 [details] [diff] [review]
patch - don't check FirefoxHTML and FirefoxURL DefaultIcon reg key

Office modifies the FirefoxHTML\DefaultIcon reg key value so we shouldn't check that value when checking if we are the default browser. I changed this when adding Vista support (I believe I did so due in an attempt to fix Bug 268512) and we didn't use to check it so this bug wasn't apparent before.
Attachment #259429 - Flags: review?(sspitzer)
looking at cvsblame, the code before your change was:

  { MAKE_KEY_NAME2(CLS, CLS_HTML, DI),  "", VAL_FILE_ICON, PATH_SUBSTITUTION | N
ON_ESSENTIAL },

So you're restoring that, and adding a comment as to why NON_ESSENTIAL is needed.  (Actually, can you explictly call out NON_ESSENTIAL in your comment before checking in?)
	
again looking at cvsblame, you've also removed NON_ESSENTIAL from this line:

  { MAKE_KEY_NAME2(CLS, CLS_HTML, SOP), "", VAL_OPEN, PATH_SUBSTITUTION | NON_ES
SENTIAL },

(where SOP == "\\shell\\open\\command", I always forget.)

So we currently have:

   { MAKE_KEY_NAME2(CLS, CLS_HTML, SOP), "", VAL_OPEN, APP_PATH_SUBSTITUTION },
   { MAKE_KEY_NAME2(CLS, CLS_URL, SOP), "", VAL_OPEN, APP_PATH_SUBSTITUTION },

Should we be adding NON_ESSENTIAL there too, or do we only need worry about DI ("\\DefaultIcon").  It appears that office uses DI, but could something else be using SOP?
(In reply to comment #1)
> looking at cvsblame, the code before your change was:
> 
>   { MAKE_KEY_NAME2(CLS, CLS_HTML, DI),  "", VAL_FILE_ICON, PATH_SUBSTITUTION |
> N
> ON_ESSENTIAL },
> 
> So you're restoring that, and adding a comment as to why NON_ESSENTIAL is
> needed.  (Actually, can you explictly call out NON_ESSENTIAL in your comment
> before checking in?)
Sure

> again looking at cvsblame, you've also removed NON_ESSENTIAL from this line:
> 
>   { MAKE_KEY_NAME2(CLS, CLS_HTML, SOP), "", VAL_OPEN, PATH_SUBSTITUTION |
> NON_ES
> SENTIAL },
> 
> (where SOP == "\\shell\\open\\command", I always forget.)
> 
> So we currently have:
> 
>    { MAKE_KEY_NAME2(CLS, CLS_HTML, SOP), "", VAL_OPEN, APP_PATH_SUBSTITUTION },
>    { MAKE_KEY_NAME2(CLS, CLS_URL, SOP), "", VAL_OPEN, APP_PATH_SUBSTITUTION },
> 
> Should we be adding NON_ESSENTIAL there too, or do we only need worry about DI
> ("\\DefaultIcon").  It appears that office uses DI, but could something else be
> using SOP?
The open commands are the really important ones and should never be modified by anyone but us for these two keys. The old behavior allowed another app to modify these values without us notifying the user that we aren't the default handler for local html files based on a value that Firefox should be the only one maintaining.
Comment on attachment 259429 [details] [diff] [review]
patch - don't check FirefoxHTML and FirefoxURL DefaultIcon reg key

r=sspitzer

thanks for vending me a clue about SOP, robert.

perhaps in addition to mentioning why need NON_ESSENTIAL for DI in the comment, you can copy and paste your answer from this bug about why it should not be added (why you removed it) for SOP?  (your call).
Attachment #259429 - Flags: review?(sspitzer) → review+
Created attachment 259442 [details] [diff] [review]
updated to comments

Carrying forward review... Thanks Seth!
Attachment #259429 - Attachment is obsolete: true
Attachment #259442 - Flags: review+
robert, do we need to worry about the installer / uninstaller at all?
Created attachment 259443 [details] [diff] [review]
correct patch updated to comments

carrying forward r=sspitzer
Attachment #259442 - Attachment is obsolete: true
Attachment #259443 - Flags: review+
(In reply to comment #5)
> robert, do we need to worry about the installer / uninstaller at all?
No, only when checking if we are the default browser. We should fix this also in Thunderbird though. I'll file a followup.
Checked in to trunk

Filed Bug 375137 for Thunderbird
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Attachment #259443 - Flags: approval1.8.1.4?
Comment on attachment 259443 [details] [diff] [review]
correct patch updated to comments

approved for 1.8.1.4, a=dveditz for release-drivers
Attachment #259443 - Flags: approval1.8.1.4? → approval1.8.1.4+
Checked in to MOZILLA_1_8_BRANCH for Firefox 2.0.0.4
Keywords: fixed1.8.1.4
verified fixed 1.8.1.4 using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.4) Gecko/2007050106 Firefox/2.0.0.4 and office 2007. Firefox is working fine as default browser and i`m not prompted to set Firefox as default browser. 

Also Firefox as default browser works fine from all standard points (url in start-search, url in mails or shortcuts on desktop).

Adding verified keyword.
Keywords: fixed1.8.1.4 → verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.