Schema out-of-date error check forces Tb to quit, so you can't disable Ln

RESOLVED FIXED in 0.7

Status

Calendar
General
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Matthew (lilmatt) Willis, Assigned: martinschroeder)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

12 years ago
Spin-off from bug 369819

Currently, the schema out-of-date error check will quit the running app, rather than allow you to possibly munge your data.

This is fine for Sunbird, but for Lightning it has the unhelpful side effect of preventing you from getting to the Add-ons Manager to disable the offending version of Lightning.

For Lightning, instead of forcing Tb to quit, we should just disable Ln.

Comment 1

12 years ago
Thanks for filing this.
If we disable the extension, then an upgrade and reenable should make it work after a restart. This seems like a good solution.
We should be able to use nsIExtensionManager.disableItem (see )http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/public/nsIExtensionManager.idl#241
(Assignee)

Updated

11 years ago
Assignee: nobody → mschroeder
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 years ago
Created attachment 264180 [details] [diff] [review]
Patch v1

I tested this patch only with Lightning. Maybe the error message for Lightning needs some adjustment.
Attachment #264180 - Flags: review?(daniel.boelzle)

Comment 3

11 years ago
Comment on attachment 264180 [details] [diff] [review]
Patch v1

>Index: calCalendarManager.js
>+ *   Martin Schr�der <mschroeder@mozilla.x-home.org>
better no umlauts: Schroeder?

>+                var errorBoxTitle;
>+                var errorBoxText;
>+                var buttonLabel;
better prefix buttonLabel with errorBox like the other variables.

>                 buttonFlags = promptSvc.BUTTON_POS_0 *
dto.

>Index: calendar.properties
>+tooNewSchemaErrorBoxTextLightning=The calendar data in your profile was updated by a newer version of %1$S, and continuing will probably cause the information to be lost or corrupted. %1$S will be disabled and %2$S now restarted.
I would favor "XXX will now be disabled and YYY restarted.".

r=dbo assuming you have properly tested the patch, because I've not ;)
Attachment #264180 - Flags: review?(daniel.boelzle) → review+
(Assignee)

Comment 4

11 years ago
Created attachment 265509 [details] [diff] [review]
Patchv2

Updated nits from review comment. Carrying forward r+.
Attachment #264180 - Attachment is obsolete: true
Attachment #265509 - Flags: review+
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed after 0.5]
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed after 0.5]
Target Milestone: --- → 0.7
You need to log in before you can comment on or make changes to this bug.