369819 - Database version warning doesn't refer to Lightning/Calendar

Status: VERIFIED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[Jay Rossiter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla-1.8 0.3.1pre 2007012705

Starting from build 2007012705 Thunderbird issues a warning on startup saying:

"The data in your profile was updated by a newer version of Thunderbird, and continuing will probably cause the information to be lost or corrupted. Thunderbird will now quit."

The dialog can be bypassed by pressing escape.

This isn't a Thunderbird issue, as reverting to the previous day's version of Lightning resolves the issue.  The issue continues through at least today's build (2007020803).

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jay Rossiter]

Attachment: Screenshot of error dialog

Comment 2

[Matthew (lilmatt) Willis]

Ya, we need to make it say "Your calendar data was..." so it's more clear.

Comment 3

[Jay Rossiter]

I'm confused.  Does this mean that the -latest nightlies have regressed from 0.4a1 to 0.3.1pre?  If so, what does that mean, and where did the 0.4 builds go?

Comment 4

[Matthew (lilmatt) Willis]

Yes. We have a limited set of tinderboxes to build _and_ release from, so in order to get the 0.3.1 maintenance release complete _before_ the US Daylight Savings Time changes come into effect, we had to switch the Lightning branch tinderbox to build 0.3.1.

As soon as we ship 0.3.1, we'll return the tinderbox to building 0.4a1/0.5pre

Comment 5

[Stefan Sitter [:ssitter]]

(In reply to comment #2)
> Ya, we need to make it say "Your calendar data was..." so it's more clear.

That's exactly what I meant in Bug 357458 Comment #17.

Comment 6

[Stefan Sitter [:ssitter]]

Updating summary and severity since the message is shown on purpose but misleading.

Comment 8

[Matthew (lilmatt) Willis]

Attachment: Adds "calendar" to the text. Changed the entity name to force l10n updates.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 256863 [details] [diff] [review]
Adds "calendar" to the text.  Changed the entity name to force l10n updates.

>-tooNewSchemaErrorText=The data in your profile was updated by a newer version of %1$S, and continuing will probably cause the information to be lost or corrupted. %1$S will now quit.
>+tooNewSchemaErrorBody=The calendar data in your profile was updated by a newer version of %1$S, and continuing will probably cause the information to be lost or corrupted. %1$S will now quit.

While this is indeed an improvement, it's not technically correct. If you only downgrade lghtning, but keep on using the same thunderbird, the message would blame thunderbird for changing the data. Which is wrong.
Would it be hard to really fix this, by saying what really changed the calendar data?

Comment 10

[cmtalbert]

Comment on attachment 256863 [details] [diff] [review]
Adds "calendar" to the text.  Changed the entity name to force l10n updates.

r=clint

Comment 11

[David Fraser]

Surely it's also wrong for Lightning to force Thunderbird to quit...
In the case of the standalone calendar application it may make sense. In the case of an extension to a mail application, it feels unfair - all that other data in my profile being denied to me...
Is it not possible to cause this to disable the extension until its cleared up rather than quitting the application? If it did that, then you could remove the calendars and re-add them from within Thunderbird...

Comment 12

[Matthew (lilmatt) Willis]

Attachment: Addresses mvl's comments

This uses the app name to be more descriptive.  Screenshot forthcoming.

Comment 13

[Matthew (lilmatt) Willis]

Attachment: Screenshot of above

Comment 14

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 257360 [details]
Screenshot of above

ui-review=mvl

Comment 15

[Sebastian Schwieger]

I think Davids comment 11 is very reasonable. How can one update Lightning to the most recent version if Thunderbird doesn't start. I know, there is safe mode, but this needs action from the user.

Comment 16

[Michiel van Leeuwen (email: mvl+moz@)]

The comment is right, but not for this bug. This bug is about cleaning up the message. There is no functionality change. Please file a new bug on the exit issue.

Comment 17

[cmtalbert]

Comment on attachment 257359 [details] [diff] [review]
Addresses mvl's comments

This looks like a better approach. r=ctalbert

Comment 18

[Matthew (lilmatt) Willis]

(In reply to comment #16)
> Please file a new bug on the exit issue.

bug 372868 has been filed for that

Comment 19

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 257359 [details] [diff] [review]
Addresses mvl's comments

r2=mvl

Comment 20

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 21

[Martin Schröder [:mschroeder]]

VERIFIED with Tb 2.0.0.x on WindowsXP when writing patch for bug 372868.