373341 - Print output is truncated after certain amount of weeks/months

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3pre) Gecko/20070309 Calendar/0.5pre

Print output is truncated after certain amount of weeks/months.

Steps to Reproduce:

1. Start Sunbird with clean profile
2. Select menu command File -> Print...
3. Select print layout 'Monthly Grid' or 'Weekly Planner'
4. Select custom date range and set 01-Jan-2007 to 31-Dez-2007
5. Check print preview / print output

Actual Results:

Monthly Grid: Only January 2007 to first week of July 2007 is shown.
Weekly Planner: Only Week 1 to Week 19 is shown.

Expected Results:
The full date range is printed.

Regression range:

Works in Sunbird/0.4a1 (2007-02-13-05)
Fails in Sunbird/0.4a1 (2007-02-13-08)

This seems to be regressed by checkin "Bug 351957, Bug 312084, Bug 361642: removing temp file, fixing preview without calendar view, waiting for async provider response"

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: rev0 - increase size of pipe buffer

During testing I noticed that the HTML read from pipe is limited to 65536 bytes. The reason is that the pipe size is limited to 16*4096 bytes if default parameters are passed to init() function. Passing PR_UINT32_MAX causes the pipe to have "infinite" space. This is basically the same solution as already used in calICSCalendar.js.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 259523 [details] [diff] [review]
rev0 - increase size of pipe buffer

r=lilmatt 
nice catch

Comment 3

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 4

[Daniel Boelzle [:dbo]]

BTW: Wouldn't the hex literal 0xffffffff be also valid and more readable?