373371 - Findbar highlighting shows background-image

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[u279076]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2

When doing a page search for "firefox" and selecting "highlight all", the highlighting on firefox in an image rendered the image as the highlighting.



Reproducible: Always

Steps to Reproduce:
1. navigate to http://www.mozilla.com/en-US/firefox/
2. press Ctrl+F
3. type in "firefox" into the find box
4. click "next"
5. click "Highlight all"

Actual Results:  
The background highlighting is the image-behind being rendered instead of the highlighting colour

Expected Results:  
The text should simply be highlighted without background image.

See screenshot:
http://farm1.static.flickr.com/127/415733763_c846816f46_o.png

This has been reported on WinXP and Linux using FF1.5, 2.0.0.2, 2.0.0.3 and Mac.

Comment 1

[Carsten Book [:Tomcat]]

confirmed for windows, mac, linux, i see the same as anthony

Comment 2

[Marek Hám]

This is because of CSS in file /style/rustico/content.css on mozilla.com. Solution of this is to add the following lines to file.

#main-feature a.download-firefox span span,
#main-feature a.download-thunderbird span span,
#main-feature .brief-feature a.download-firefox span span
{
  background-image: none;
}

Sorry for my English.

Comment 3

[Marek Hám]

My next solution is shorter, but it depends on id defined in file http://lxr.mozilla.org/mozilla1.8/source/toolkit/components/typeaheadfind/content/findBar.js on lines 276 and 311.

#main-feature #__firefox-findbar-search-id {
  background-image: none;
}

Comment 4

[[:Aleksej]]

Sorry for confirming it without thinking, it should be a duplicate of bug 263683, IMO. :)

Comment 5

[Stephanie Daugherty [:sdaugherty]]

duplicate per #4

Comment 6

[Marek Hám]

Sorry, but I can't create a patch file, then I post file with descriptions of changes on branches 1.8 and 1.8.0.

I will learn working with CVS soon. ;)

Comment 7

[Marek Hám]

Attachment: Path for findBar.js on branches 1.8 and 1.8.0

Comment 8

[Marek Hám]

Attachment: Patch for 1.8 Branch

Comment 9

[Marek Hám]

Attachment: Patch for 1.8 Branch

Comment 10

[Steffen Wilberg]

Reopening. This bug is about one of the symptoms of the findbar highlighting, showing a background-image were it shouldn't.

Bug 263683 is about reworking the findbar highlighting by using selections instead of manipulating the DOM (adding <span>s all over the place). Fixing bug 263683 would probably fix this bug as well, but it's not the same bug.

Marek, the 1.8 branch is mainly for security fixes. On the trunk, the code has been refactored into findbar.xml. You might want to patch this:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/content/widgets/findbar.xml&rev=1.14#544

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The design on mozilla.com was changed. So the testcase doesn't work anymore or I'm not able to see a similar issue. Anyone, who can give us a new testcase?

Comment 12

[Martijn Wargers (dead)]

Attachment: testcase

This is working correctly now that bug 263683 is fixed.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks for the testcase, Martijn; verified fixed using https://bugzilla.mozilla.org/attachment.cgi?id=332343, with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1a2pre) Gecko/2008080504 Minefield/3.1a2pre

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Should we have the testcase in the test-suite or at least in Litmus?

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Per discussion with Martijn, he will create an automated test (reftest) for that issue.

Comment 16

[Martijn Wargers (dead)]

With a little tweak of the reftest in bug 263683, this bug could be tested too.
But the reftest still depends on bug 448676, since it needs to have enhanced privileges.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #16)
> With a little tweak of the reftest in bug 263683, this bug could be tested too.
> But the reftest still depends on bug 448676, since it needs to have enhanced
> privileges.

In that case we should add the bug to the depends list to get a notification when its possible.

Comment 18

[Martijn Wargers (dead)]

Sorry, I was wrong, bug 448676 might be invalid/wontfix. It probably more depends on bug bug 374458 or bug 430652, see bug 263683, comment 53.

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mmh, so we better should keep track of it in bug 263683?