If opening file for writing error occurs during installation, text in displayed dialog is not interpreted correctly. Text contains line breaks ('\r\n'). These are ignored and displayed as plain text.

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: wladow, Assigned: rstrong)

Tracking

({verified1.8.1.5})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; sk; rv:1.8.1.3pre) Gecko/20070313 BonEcho/2.0.0.3pre
Build Identifier: Latest nightlies (Mozilla1.8 branch) of products that use NSIS installer

This affects probably all locales including en-US, 
confirmed in Firefox 2.0.0.2 en-US final (see attachment nr1)
and Thunderbird 2.0pre sk nightlies (see attachment nr2)
 

Reproducible: Always

Steps to Reproduce:
I did not managed to reproduce this, attached screenshots are grabbed from Mozilla.sk end-user support forum.
Actual Results:  
Line breaks ('\r\n') are not interpreted correctly

Expected Results:  
Line breaks ('\r\n') should be interpreted correctly :)
Created attachment 258583 [details]
Firefox 2.0.0.2 en-US installer error
Created attachment 258584 [details]
Thunderbird 2.0pre sk nightly installer error

Comment 4

12 years ago
Copying comment over from bug 374806, that's the FileError_NoIgnore string,
http://mxr.mozilla.org/mozilla1.8/search?string=FileError_NoIgnore, called in
from MessageBox at 
http://mxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/installer/windows/nsis/common.nsh#1898
I didn't find any insightful documentation at 
http://www.nullsoft.com/free/nsis/makensis.htm#MessageBox, but I guess that's
assuming to be a single line string?
Status: UNCONFIRMED → NEW
Ever confirmed: true
What happened is we re-used a string that wasn't meant for a messagebox for a bug fixed in 2.0.0.1 (e.g. no new strings) so it isn't escaped appropriately. What we need to do is escape it appropriately in DisplayCopyErrMsg
http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/installer/windows/nsis/common.nsh#1887
Assignee: nobody → robert.bugzilla
fixed by the checkin of Bug 369221
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
fixed on the MOZILLA_1_8_BRANCH by the checkin of Bug 369221
Keywords: fixed1.8.1.5
I created a dummy file called "firefox.exe" (its type was "application") and placed it in C:\Program Files\BonEcho2005.  Next, I ran the 2.0.0.5 installer and choose that directory into which to install.  I found none of the issues mentioned in this bug or in its duplicates.

Replacing fixed1.8.1.5 with verified1.8.1.5 from my testing on:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5pre) Gecko/20070711 BonEcho/2.0.0.5pre
Keywords: fixed1.8.1.5 → verified1.8.1.5
You need to log in before you can comment on or make changes to this bug.