374012 - Use transactions inside of Bugzilla::Object

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[Max Kanat-Alexander]

The simplest place to use a transaction is inside of Bugzilla::Object->create and Bugzilla::Object->update.

Because transactions are nestable in Bugzilla, it's easy to add them there, and then later add them into CGIs. Also, anybody who overrides create() or update() will probably want to do their own transaction stuff.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Hey Kevin, you like MySQL stuff and DB stuff and so forth, yeah? :-) Feel comfortable reviewing my transaction changes?

I've tested this code on landfill. Basically, adding bz_start_transaction and bz_commit transaction anywhere in the code is entirely harmless, since they're nestable. But I still have to ask for review anyhow. :-)

Comment 2

[Frédéric Buclin]

Comment on attachment 258625 [details] [diff] [review]
v1

Seems to work fine. r=LpSolit

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla/Object.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Object.pm,v  <--  Object.pm
new revision: 1.14; previous revision: 1.13
done