374016 - Use transactions to create bugs

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[Max Kanat-Alexander]

This is a lot easier than for process_bug.cgi.

We need the transactions to happen inside of Bugzilla::Bug (for things like XML-RPC) and also in post_bug (for normal web bug-entry).

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay. I've tested this, it seems to work just fine.

I actually don't think we even really need to lock longdescs--what possible race condition could occur on that table there (other than having a rollback and leaving a comment in the table with an invalid bug ID).

Comment 2

[:glob ✱]

     $dbh->bz_unlock_tables();
+    $dbh->bz_commit_transaction();

shouldn't bz_unlock_tables be nuked?

Comment 3

[Max Kanat-Alexander]

Attachment: v2

Okay, I thought about this some more, and I think what's most important right now is to avoid the "orphan comment" if something causes us to rollback.

So I'm not using transactions in post_bug.cgi, and we'll just have to work on Bug::create supporting attachments and so on.

Comment 4

[Max Kanat-Alexander]

(In reply to comment #2)
>      $dbh->bz_unlock_tables();
> +    $dbh->bz_commit_transaction();
> 
> shouldn't bz_unlock_tables be nuked?

  In that version of the patch I was still locking longdescs, and committing may implicitly unlock tables in MySQL, but it doesn't unlock them as far as Bugzilla knows.

Comment 5

[Frédéric Buclin]

Comment on attachment 258628 [details] [diff] [review]
v2

Works fine on both MySQL 5.0.24 and Pg 8.1.8. r=LpSolit

Comment 6

[Max Kanat-Alexander]

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.176; previous revision: 1.175
done