374491 - audit the .dtd / .properties files in places and remove unused strings

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

audit the .dtd / .properties files in places and remove unused strings

spun off from today's l10n meeting.

Comment 2

[(not reading, please use [e-mail] instead)]

see also mozilla/browser/locales/en-US/profile/bookmarks.html, which gets used on a new profile.

Comment 3

[u60234]

These entities in places.dtd are not used, entities from global/locale/editMenuOverlay.dtd are used instead:

<!ENTITY cmd.select_all.label "Select All">
<!ENTITY cmd.select_all.accesskey "A">
<!ENTITY cmd.select_all.key "a">

<!ENTITY cmd.edit_cut.label         "Cut">
<!ENTITY cmd.edit_cut.accesskey     "t">
<!ENTITY cmd.edit_cut.key           "x">
<!ENTITY cmd.edit_copy.label        "Copy">
<!ENTITY cmd.edit_copy.accesskey    "C">
<!ENTITY cmd.edit_copy.key          "c">
<!ENTITY cmd.edit_paste.label       "Paste">
<!ENTITY cmd.edit_paste.accesskey   "P">
<!ENTITY cmd.edit_paste.key         "v">
<!ENTITY cmd.edit_delete.label      "Delete">
<!ENTITY cmd.edit_delete.accesskey  "D">
<!ENTITY cmd.edit_undo.label        "Undo">
<!ENTITY cmd.edit_undo.accesskey    "U">
<!ENTITY cmd.edit_undo.key          "z">
<!ENTITY cmd.edit_redo.label        "Redo">
<!ENTITY cmd.edit_redo.accesskey    "R">
<!ENTITY cmd.edit_redo.key          "y">

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 5

[Tyler Downer [He/Him]]

Attachment: WIP 1

Just covers the places.dtd so far

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 443784 [details] [diff] [review]
WIP 1

Looks good, and i can't see use of those.

Comment 7

[Marco Bonardo [:mak]]

please do in multiple patches, one per file.

Comment 8

[Marco Bonardo [:mak]]

Notice in Bug 563031 KaiRo has done some analysis and you can gather data from there

Comment 9

[Tyler Downer [He/Him]]

Attachment: places.dtd patch v1

Ok, there were a few lines that I missed, I think this covers them all now.

Comment 10

[Tyler Downer [He/Him]]

Attachment: places.properties patch v1

This covers places.properties.

Comment 11

[Tyler Downer [He/Him]]

Attachment: editBookmarkOverlay.dtd patch v1

This covers editBookmarkOverlay.dtd

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 443797 [details] [diff] [review]
places.dtd patch v1

>diff --git a/browser/locales/en-US/chrome/browser/places/places.dtd b/browser/locales/en-US/chrome/browser/places/places.dtd
> <!ENTITY search.label                              "Search:">
> <!ENTITY search.accesskey                          "S">
>-<!ENTITY search.scopeFolder.label                  "Selected Folder">
>-<!ENTITY search.scopeFolder.accesskey              "r">

This is in http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.xul#409

>-<!ENTITY saveSearch.label                          "Save">
>-<!ENTITY saveSearch.accesskey                      "S">

this one in http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.xul#415

>-<!ENTITY detailsPane.selectAnItemText.description "Select an item to view and edit its properties">
>+<!ENTITY detailsPane.selectAnItemText.description "Select an item to view and edit its properties">

What causes this last line change? newline? Or is it just a diff glitch?

>\ No newline at end of file

Please add new line at the end of the file

Comment 13

[Marco Bonardo [:mak]]

Comment on attachment 443801 [details] [diff] [review]
places.properties patch v1

>diff --git a/browser/locales/en-US/chrome/browser/places/places.properties b/browser/locales/en-US/chrome/browser/places/places.properties

>-sortByName=Sort '%S' by Name
>-sortByNameGeneric=Sort by Name
>-view.sortBy.name.label=Sort by Name
>-view.sortBy.name.accesskey=N
>-view.sortBy.url.label=Sort by Location
>-view.sortBy.url.accesskey=L
>-view.sortBy.date.label=Sort by Visit Date
>-view.sortBy.date.accesskey=V
>-view.sortBy.visitCount.label=Sort by Visit Count
>-view.sortBy.visitCount.accesskey=C
>-view.sortBy.keyword.label=Sort by Keyword
>-view.sortBy.keyword.accesskey=K
>-view.sortBy.description.label=Sort by Description
>-view.sortBy.description.accesskey=D
>-view.sortBy.dateAdded.label=Sort by Added
>-view.sortBy.dateAdded.accesskey=e
>-view.sortBy.lastModified.label=Sort by Last Modified
>-view.sortBy.lastModified.accesskey=M
>-view.sortBy.tags.label=Sort by Tags
>-view.sortBy.tags.accesskey=T

these are used (name is builkt dynamically) http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.js#1212

> OrganizerQueryHistory=History
>-OrganizerQueryDownloads=Downloads
> OrganizerQueryAllBookmarks=All Bookmarks
> OrganizerQueryTags=Tags

Please leave Downloads in even if we don't use it, i think is being worked on right now

>-# LOCALIZATION NOTE (tagResultLabel) :
>-# This is what we use to form the label (for screen readers)
>-# for url bar autocomplete results of type "tag"
>-# See createResultLabel() in urlbarBindings.xml 
>-tagResultLabel=Tag
>-# LOCALIZATION NOTE (bookmarkResultLabel) :
>-# This is what we use to form the label (for screen readers)
>-# for url bar autocomplete results of type "bookmark"
>-# See createResultLabel() in urlbarBindings.xml 
>-bookmarkResultLabel=Bookmark

These are used http://mxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#695

>-lockPromptInfoButton.accessKey=L
>+lockPromptInfoButton.accessKey=L
>\ No newline at end of file

Same as previous patch

Comment 14

[Marco Bonardo [:mak]]

Comment on attachment 443803 [details] [diff] [review]
editBookmarkOverlay.dtd patch v1

>diff --git a/browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd b/browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd
>--- a/browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd
>+++ b/browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd
>@@ -1,10 +1,8 @@
>-<!ENTITY editBookmarkOverlay.name.label                      "Name:">
>-<!ENTITY editBookmarkOverlay.name.accesskey                  "N">

used http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/editBookmarkOverlay.xul#63

>-<!ENTITY editBookmarkOverlay.newFolderButton.accesskey       "o">
>+<!ENTITY editBookmarkOverlay.newFolderButton.accesskey       "o">
>\ No newline at end of file

same as previous patches

Comment 15

[Tyler Downer [He/Him]]

I think the last change is a whitespace thing. I can take that out. I'll put those strings back in and get us going here ;)

Comment 16

[Marco Bonardo [:mak]]

Thank you, I really appreciate your effort here!

Comment 17

[Tyler Downer [He/Him]]

Attachment: places.dtd patch v2

Ok, I think this address all the comments on places.dtd

Comment 18

[Tyler Downer [He/Him]]

Comment on attachment 443803 [details] [diff] [review]
editBookmarkOverlay.dtd patch v1

nothing needs to be taken from here then :)

Comment 19

[Marco Bonardo [:mak]]

(In reply to comment #18)
> (From update of attachment 443803 [details] [diff] [review])
> nothing needs to be taken from here then :)

you could add the missing newline at the end of the file though!

Comment 20

[Tyler Downer [He/Him]]

Looking in there, I took that newline out when I created the patch, so, there is a newline already ;) I didn't realize it at first. Sorry for the confusion

Comment 21

[Tyler Downer [He/Him]]

Attachment: places.properties patch v2

Here is places.properties :)

Comment 22

[Marco Bonardo [:mak]]

Comment on attachment 443961 [details] [diff] [review]
places.dtd patch v2

>diff --git a/browser/locales/en-US/chrome/browser/places/places.dtd b/browser/locales/en-US/chrome/browser/places/places.dtd

>-<!ENTITY view.unsorted.label            "Unsorted">
>-<!ENTITY view.unsorted.accesskey        "U">

argh dunno how i missed this before, but it's used, sorry my fault :(
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.xul#304

Will be perfect once this is fixed

Comment 23

[Marco Bonardo [:mak]]

Comment on attachment 443971 [details] [diff] [review]
places.properties patch v2

Looks perfect! thanks!

Comment 25

[Tyler Downer [He/Him]]

Attachment: places.dtd patch v3

Ok, there it is I think :)

Comment 26

[Dão Gottwald [::dao]]

http://hg.mozilla.org/mozilla-central/rev/40dc6e65a824

Comment 27

[Vlado Valastiak [:wladow]]

Comment on attachment 443971 [details] [diff] [review]
places.properties patch v2

> # LOCALIZATION NOTE (bookmarksBackupFilename) :
> # %S will be replaced by the current date in ISO 8601 format, YYYY-MM-DD.
> # The resulting string will be suggested as a filename, so make sure that you're
> # only using characters legal for file names. Consider falling back to the
> # en-US value if you have to use non-ascii characters.
>-bookmarksBackupFilename=Bookmarks %S.html
>-bookmarksBackupFilenameJSON=Bookmarks %S.json

The localization note should be removed as well...

Comment 28

[Marco Bonardo [:mak]]

(In reply to comment #27)
> (From update of attachment 443971 [details] [diff] [review])
> > # LOCALIZATION NOTE (bookmarksBackupFilename) :

> The localization note should be removed as well...

Right, we need a followup push

Comment 29

[Marco Bonardo [:mak]]

Pushed removal of the no more useful note:
http://hg.mozilla.org/mozilla-central/rev/549f77777959

Thanks for the notice.