374977 - Enable FireVox to find the window with readable context

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[:Gijs (he/him)]

To do this, we just need to set window.content to the output window from setCurrentObject. This will enable FireVox to find the window with readable context exactly as it does in FireFox itself. This means chat gets read easily. We probably want to tweak that stuff a bit more later, but this is the ground work that needs to be done anyway. And fortunately it's a really easy change. :-)

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Well, yeah. Just another patch. Making sure not to break the world by checking we get a reasonable object.

Comment 2

[James Ross]

Comment on attachment 259366 [details] [diff] [review]
Patch

Why not put the new code after the same-object check?

Comment 3

[:Gijs (he/him)]

Attachment: Better Patch

Short answer: cause I'm an idiot.

Long answer: because initially I tried to set window._content, when that didn't work I thought it would be because by the time setCurrentObject fired for *client*, that's already the right object and hence having the setter after that line was causing it (I initially had it there). Little did I know (the error console doesn't show this...) that you can't actually set window._content - and that was causing it not to show up. They want you to set window.content instead.

Comment 4

[:Gijs (he/him)]

eh, and obviously I tested this and it does in fact work. Doh! :-)

Comment 5

[James Ross]

Comment on attachment 259412 [details] [diff] [review]
Better Patch

r=silver, though I'd like a short little comment above the the if to say we're setting window.content so accessibility applications stand a better chance of working.

Comment 6

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.237; previous revision: 1.236
done