375484 - change ORGANIZER_ROOT_BOOKMARKS to exclude queries

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

working on bug #369813, I ran into the following problem.

For bug #369813, I'm modifying load() in tree.xml to open any containers that we persist as open.

but for the bm manager dialog, findNode() is closing them because we are calling 

from http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/tree.xml#150

150           function findNode(container, placeURI) {
151             container.containerOpen = true;
152             for (var i = 0; i < container.childCount; ++i) {
153               var child = container.getChild(i);
154               if (child.uri == placeURI)
155                 return child;
156               else if (PlacesUtils.nodeIsContainer(child)) {
157                 var nested = findNode(asContainer(child), placeURI);
158                 if (nested)
159                   return nested;
160               }
161             }
162             container.containerOpen = false;
163             return null;
164           }

the reason is we fail to find the root, so we close all the containers.

I can fix this by changing ORGANIZER_ROOT_BOOKMARKS to be "place:&folder=2&group=3&excludeItems=1&excludeQueries=1";

in the code, asaf writes:

http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/places.js#195

195     // Unset excludeQueries so incremental update is enabled for the content
196     // pane.
197     // XXXmano: remove that once we unset excludeQueries for the left pane.
198     options.excludeQueries = false;

I need to check if I've broken this for new subfolders.

Comment 1

[Asaf Romano (gone)]

The change I'm doing in 371076 should fix this issue.

Comment 2

[(not reading, please use [e-mail] instead)]

invalid.

Comment 3

[(not reading, please use [e-mail] instead)]

to elaborate, invalid because of asaf's comment and recent tests with my code against the trunk (after his fix for bug #371076).  also, neil is working on bug #369813

That said, there may be an issue lurking in findNode() [http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/tree.xml#164]

For example, are the following equivalent?

place:folder=2&group=3&excludeItems=1&queryType=0
place:folder=2&group=3&excludeItems=1

(0 == QUERY_TYPE_HISTORY, the default)

since findNode() does a string compare, it would not find them to be the same.

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv