Strange button in the Add Bookmark dialog

RESOLVED FIXED in Firefox 3 alpha4

Status

()

defect
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: hidenosuke, Assigned: hidenosuke)

Tracking

unspecified
Firefox 3 alpha4
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 2 obsolete attachments)

(Assignee)

Description

12 years ago
Add Bookmark dialog has been changed by bug 357316.
But new Add Bookmark dialog has a button that has
no label.
I think this button is used to show Bookmark tree.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a4pre) Gecko/20070328 Minefield/3.0a4pre
Posted file example style (obsolete) —
1. Pinstripe has the style for #expander.
http://lxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/places/bookmarkProperties.css#64
2. Winstripe has not the style for #expander.
3. In case of Non Places Add Bookmark dialog, XUL file (addBookmark2.xul) use arrow.css.
http://lxr.mozilla.org/mozilla/source/browser/components/bookmarks/content/addBookmark2.xul#43
4. In case of Places Add Bookmark dialog, XUL file (bookmarkProperties.xul) not use arrow.css.
http://lxr.mozilla.org/mozilla/source/browser/components/places/content/bookmarkProperties.xul#40
I think that a similar style is necessary also for bookmarkProperties.css of Winstripe.
fix mistake
Attachment #259899 - Attachment is obsolete: true
I'm seeing this on windows, too.
OS: Linux → All
Hardware: PC → All

Comment 5

12 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/2007032804 Minefield/3.0a4pre [enable-places-bookmarks]

"assertion failed" after clicking "Bookmarks" in menubar.
http://img219.imageshack.us/img219/7357/afjw0.jpg

"add bookmark" dialog.
http://img474.imageshack.us/img474/1228/ab1da9.jpg
(Assignee)

Comment 6

12 years ago
(In reply to comment #5)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/2007032804
> Minefield/3.0a4pre [enable-places-bookmarks]
> 
> "assertion failed" after clicking "Bookmarks" in menubar.
> http://img219.imageshack.us/img219/7357/afjw0.jpg
> 
> "add bookmark" dialog.
> http://img474.imageshack.us/img474/1228/ab1da9.jpg

I can't see any warnings/errors.
I think your problem is the another one.
Today's build is the same as attachment 259891 [details] for me.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a4pre) Gecko/20070329 Minefield/3.0a4pre
(In reply to comment #2)
> Created an attachment (id=259900) [details]
> example style (fix mistake)
> 
> fix mistake
> 

Hello Hideo, thanks for the change! Can you please create a patch using the guidelines here: http://developer.mozilla.org/en/docs/Creating_a_patch?
Blocks: 370099
(Assignee)

Comment 8

12 years ago
Posted patch Patch for attachment 259900. (obsolete) — Splinter Review
I made a patch for attachment 259900 [details].
Thanks, Misaki-san.
Oshima-san, you breaks the copy right credit. You should open/save the code with UTF-8.
converting to UTF-8 the credit
Attachment #260879 - Attachment is obsolete: true
Attachment #260885 - Flags: review?(mano)
Without the license header change...

mozilla/browser/themes/winstripe/browser/places/bookmarkProperties.css 1.8
Assignee: mano → hidenosuke
Target Milestone: --- → Firefox 3 alpha4
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 14

12 years ago
Asaf, thanks to check in.

Updated

12 years ago
Blocks: 380387
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.