375697 - adblock breaks layout of nearly all pages on this site

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[aaront]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.4pre) Gecko/20070325 Camino/1.1b+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.4pre) Gecko/20070325 Camino/1.1b+

When ad blocking is turned on, all pages on the http://www.vancouver.wsu.edu site that use their current template render badly.  The problem seems to come from the fact that the site uses a div called "masthead_links" for a chunk of links in the top right corner.  The front page is laid out correctly and is only missing these links, but all interior pages are badly broken.

This seems to be caused by the line:

div[id*="ad_links"],

in ad_blocking.css, which blocks "masthead_links".  Can this be changed so that it blocks more specifically?  This only turned up in the beta 1.1 and newer, at least that I noticed.

Reproducible: Always

Steps to Reproduce:
1. go to http://www.vancouver.wsu.edu
2. click on any links on that page to see how badly they're broken
3.
Actual Results:  
top right links are removed and this somehow causes the left navbar to shift over to the center, pushing other content over as well.

Expected Results:  
Page should render normally, as it does with ad blocking turned off

Using default theme, no plugins.

Comment 1

[Chris Lawson (gone)]

Odd. Using version 2007032305 (1.1b+), I don't see this problem at all.

Are you sure you aren't using a custom userContent.css file anywhere?

Comment 2

[Chris Lawson (gone)]

Oh, never mind. It's any page there EXCEPT the home page. I'll fix that in the URL field ;)

cl

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yeah, we need to fix that.

The div we were trying to block was "ad_links_bottom", and smorgan said to use the more generic one ;) in bug 362330 comment 21.

Comment 4

[Stuart Morgan]

How about ^= instead of *=?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FIXED by bug 372612.