375745 - Unsubscribing from feeds still shows in list until manager is closed

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.666 - Build ID: 2007032620

Subscribe to the following feeds:
https://addons.mozilla.org/de/firefox/browse/type:1/cat:all/sort:updated/format:rss
https://addons.mozilla.org/de/thunderbird/browse/type:1/cat:all/sort:updated/format:rss
https://addons.mozilla.org/de/seamonkey/browse/type:1/cat:all/sort:updated/format:rss
https://addons.mozilla.org/de/sunbird/browse/type:1/cat:all/sort:updated/format:rss
Close the feed manager and restart Thunderbird (don't know if necessary). Go to the feed manager via context menu and remove the seamonkey and the sunbird feed. Both still show up in the list. Now close the the feed manager and reopen it. The removed feeds are gone. Was able to reproduce.

Comment 1

[Magnus Melin [:mkmelin]]

Yep, in the Error Console I get:

Error: server has no properties
Source File: chrome://messenger-newsblog/content/utils.js
Line: 232

Comment 2

[Christian Schmidt]

Attachment: Patch

Feed.server wasn't initialized, and that caused problems in Feed.invalidateItems() that calls getItemsDS(this.server).

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 301042 [details] [diff] [review]
Patch

Looks good, thx for the patch! I can check it in for you later today.

Comment 4

[Christian Schmidt]

Thanks.

Is a low-risk fix like likely to be accepted for the Thunderbird 2.0 branch? In that case I can try to roll a 2.0 build and see if it also works there.

Comment 5

[Magnus Melin [:mkmelin]]

It might... I would assume the patch applies to branch as is. You can ask for approval if it does.

For future reference, it's easer to review/and apply if you do the cvs diff standing in the mozilla dir.

Checking in mail/extensions/newsblog/content/feed-subscriptions.js;
/cvsroot/mozilla/mail/extensions/newsblog/content/feed-subscriptions.js,v  <--  feed-subscriptions.js
new revision: 1.23; previous revision: 1.22
done

->FIXED

Comment 6

[Christian Schmidt]

Comment on attachment 301042 [details] [diff] [review]
Patch

The patch also works for MOZILLA_1_8_BRANCH. I assume approval1.8.1.12 is the right flag to request for inclusion in the next Thunderbird 2.0.0.x release?

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 301042 [details] [diff] [review]
Patch

Already into code-freeze, moving request to next release

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 301042 [details] [diff] [review]
Patch

approved for 1.8.1.13, a=dveditz for release-drivers

Comment 9

[Christian Schmidt]

Requesting check-in on branch - thanks.

Comment 10

[Magnus Melin [:mkmelin]]

For branch-only checkins it's not necessary to reopen. checkin-needed keyword and a note that it's a branch checkin on the whiteboard is sufficient. 

1.8 BRANCH:
Checking in mail/extensions/newsblog/content/feed-subscriptions.js;
/cvsroot/mozilla/mail/extensions/newsblog/content/feed-subscriptions.js,v  <--  feed-subscriptions.js
new revision: 1.13.2.3; previous revision: 1.13.2.2
done

Comment 11

[Mike Cowperthwaite]

I can verify that this appears to work as expected (TB 3.0a1pre (2008021703)); but see bug 267082 comment 16.

Comment 12

[Al Billings [:abillings - ex-MoCo]]

I verified this in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.14) Gecko/2008042109 Thunderbird/2.0.0.14. The feeds will get moved to the trash, which can then be emptied to delete them.