376089 - open .eml files from the command line using relative path fails

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Elmar Stellnberger]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1.3) Gecko/20070320 SUSE/2.0.0.3-3.1 Firefox/2.0.0.3
Build Identifier: 2.0.0.0pre (20070329)

There is no program for viewing .eml-files under Linux.
Opening .eml-Files from the command line with Thunderbird would also enable opening them directly from a file browser like konqueror.
Moreover an eml-viewer plugin for konqueror would be no replacement for this feature request since the user may also want to edit and save emls stored as file.

Reproducible: Always

Steps to Reproduce:
1. open command line
2. enter: thunderbird mysaved.eml


Actual Results:  
nothing happens

Expected Results:  
Thunderbird should open the mail.
If Thunderbird is already open this should happen very fast by sending an open request to the already running Thunderbird process.

Bug 351064 describes a similar problem when trying to open an .eml message from within Thunderbird. Nevertheless for Linux users it will be important to open emls   by directly invoking Thunderbird with appropriate parameters.

Comment 1

[Magnus Melin [:mkmelin]]

Hmm, it does work if I enter thunderbird /whole/path/to/eml/msg.eml but not with a relative path. In both cases I get this in the error console:

Error: [Exception... "'Failure' when calling method: [nsICommandLineHandler::handle]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "<unknown>"  data: no]

Comment 2

[Elmar Stellnberger]

I have not found out yet what the problem is on my machine.
Simply nothing happens if I type:
> thunderbird /home/elmar/Dokumente/Korrespondenz/\[JMLC2006\]\ Paper\ 14.eml
Nothing; not even an error message!

Comment 3

[Elmar Stellnberger]

OK. The path must be an absolute one and the file name must not contain any spaces.

Comment 4

[[:Aleksej]]

version 2.0.0.0 (20070326) (rc2)
Debian GNU/Linux 4.0testing

Full path works, no matter what characters in the name (spaces, "[", "]", and "\", and some non-ASCII ones, but the latter don't need to be escaped).
Relative path (including a file in the current directory) doesn't work, no other error messages than those with a full path (not related to the bug itself).

Comment 5

[Carsten Book [:Tomcat]]

because of comment #1 and #4 ..changing to bug

Comment 6

[Arie Paap [:wildmyron]]

On WinXP SP2 with Tb2-rc1 I see the following behaviour:

1) Tb not running
Full path always works
Relative path - Tb starts up but eml does not open. Error message:

Error: startFolder has no properties
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 999

2) Tb already running
Full path works
Relative path does not work.
In both of these cases I see the nsICommandLineHandler::handle error.

Wildmyron

Comment 7

[Magnus Melin [:mkmelin]]

->NEW

Comment 8

[Elmar Stellnberger]

  When opening an .eml as the attechment of a message currently being viewed by Thunderbird it should not ask for a program to open the eml with but simply view the .eml-File as any other email.

Comment 9

[Magnus Melin [:mkmelin]]

It does - but even if you have problems with that it's totally unrelated to this bug.

Comment 10

[Noèl Köthe]

I can reproduce this bug very easily.

A running 2.0.0.17 thunderbird:

# thunderbird email.eml

No windows opens

# thunderbird /home/user/email.eml

opens windows with the expected windows.

Comment 11

[Magnus Melin [:mkmelin]]

Taking.

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Use ResolveFile to resolve the path, show an error dialog if the file does not exist.

Comment 13

[David :Bienvenu]

Comment on attachment 364505 [details] [diff] [review]
proposed fix

thx, Magnus, this wfm.

Comment 14

[Magnus Melin [:mkmelin]]

changeset:   2140:329c16f96d25
http://hg.mozilla.org/comm-central/rev/329c16f96d25

->FIXED