376428 - Check for updates window closes by itself if no update available

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Bill Gianopoulos [:WG9s]]

If you do Help -> Check for updates, and no update is available, the window closes by itself after 1 second, just as if you had clicked on Finish.  I am trying to narrow down a regression window for this.

Comment 1

[Bill Gianopoulos [:WG9s]]

By narrowing the regression window, this seems to be caused by the checkin for bug 366478.

Comment 2

[Neil Deakin]

I'll bet this is because the wizard uses a 'pageshow' event which is the same event as the bfcache 'pageshow' event. So, the fix is probably to remove the XUL indicator in the event table for pageshow/pagehide in nsContentUtils.cpp and not support the bfcache events as attributes in XUL.

Comment 3

[Bill Gianopoulos [:WG9s]]

Bug 366478 has been verified as the cause via backout.

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

This error is in the JS Console when checking for updates, and also appears when trying to check for updates to extensions via: Tools->Addons: Find Updates


Error: [Exception... "'Component does not have requested interface' when calling method: [nsIInterfaceRequestor::getInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "<unknown>"  data: no] 

Addons also reports on different extensions:  An error occured... blah blah blah.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a4pre) Gecko/20070403 Minefield/3.0a4pre Firefox ID:2007040318 [cairo]

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to comment #4)
> This error is in the JS Console when checking for updates, and also appears
> when trying to check for updates to extensions via: Tools->Addons: Find Updates
> 
> 
> Error: [Exception... "'Component does not have requested interface' when
> calling method: [nsIInterfaceRequestor::getInterface]"  nsresult: "0x80004002
> (NS_NOINTERFACE)"  location: "<unknown>"  data: no] 
> 
> Addons also reports on different extensions:  An error occured... blah blah
> blah.
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a4pre) Gecko/20070403
> Minefield/3.0a4pre Firefox ID:2007040318 [cairo]
> 

These error messages pre-date the problem being discussed here and are a completely seperate issue.

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to comment #2)
> I'll bet this is because the wizard uses a 'pageshow' event which is the same
> event as the bfcache 'pageshow' event. So, the fix is probably to remove the
> XUL indicator in the event table for pageshow/pagehide in nsContentUtils.cpp
> and not support the bfcache events as attributes in XUL.
> 

I tried that and it does resolve the issue.  I ave no idea what else to check though to see if that causes a regression elsewhere.

Comment 7

[Neil Deakin]

Attachment: don't use pageshow/pagehide events in xul

Only parse the onpageshow/onpagehide attributes used for bfcache on html elements so that they don't conflict with the similarly named attributes used in the XUL <wizard> element.

Comment 8

[aja+bugzilla]

Just for the sake of completeness and searchability...these 2 messages show up in the error console:

Error: gUpdates.wiz has no properties
Source file: chrome://mozapps/content/update/updates.js
Line: 657

and

Error: this.wiz has no properties
Source file: chrome://mozapps/content/update/updates.js
Line: 192

Comment 9

[aja+bugzilla]

WFM now with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070404 Minefield/3.0a4pre ID:2007040411 [cairo]

Comment 10

[-fullmetaljacket-]

yup, now fixed!