Closed Bug 376638 Opened 18 years ago Closed 10 years ago

should warn if developer uploads with version number that is considered to less than an existing version

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect, P5)

Product:
addons.mozilla.org Graveyard
Component:
Developer Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
4.x (triaged)

People

(Reporter: shaver, Unassigned)

References

Details

FEBE 4.0.4p was uploaded in March, but won't be offered to users who have 4.0.4 installed, because 4.0.4 sorts after 4.0.4p according to the toolkit version format spec. Since it will almost *never* be what a developer wants to upload a new version that doesn't supercede (The add-on display page shows the right version, though, so maybe we should just use the same algorithm for selecting that? If so, I'll file another bug about that and we can leave this one as a low-priority nice-to-have thingy.)
Severity: normal → minor
Target Milestone: --- → 3.x (triaged)
It would probably be easy to add this as another check in the validator.
Priority: -- → P5
Assignee: nobody → mbasta
Target Milestone: 4.x (triaged) → 5.12.4
What exactly is the validator going to be looking at for this?
From the install.rdf, the em:version tag contains a toolkit number which has to be bigger than the previous uploaded one (keep in mind release and beta branch of the add-ons, i.e. uploading a bug fix can likely have a lower version than the latest add-on beta release). If the version number is lower, there should be a warning. If it is equal, it would be added to the current version (but be pending review) and I don't know if there is already something which checks files with the same version for target platform conflicts.
If this is something that interacts with the db, we can kick it out of this milestone.
Target Milestone: 5.12.4 → 4.x (triaged)
Since it's not necessarily a dynamic query to the database, I could just add a parameter for the error bundle that could be specified when the task is created. The DB lookup would be performed before the validation and the validator would do it's thing when celery gets around to it. If that's not ideal, then we can bump this.
Assignee: mbasta → nobody
Closing due to lack of activity, please re-open if you'd like to work on it.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.