Closed
Bug 376675
Opened 19 years ago
Closed 19 years ago
Don't package regxpcom.exe
Categories
(Thunderbird :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mscott, Assigned: mscott)
Details
(Keywords: verified1.8.1.4)
Attachments
(1 file)
|
973 bytes,
patch
|
mkmelin
:
review+
dveditz
:
superreview+
dveditz
:
approval1.8.1.4+
|
Details | Diff | Splinter Review |
We noticed this while making the thunderbird 2 builds:
"
> * regxpcom.exe differs after both partial & complete updates, it
> doesn't seem to be included in the mars but is in the installer
Shipping it is probably a mistake, regxpcom is a dev util that isn't needed
by users. On the other hand it looks like we've been shipping this thing
since Tbird 1 (but we don't ship it with Firefox)."
|
Assignee | |
Comment 1•19 years ago
|
||
Don't package regxpcom.exe
Add regxpcom.exe to the removed-files list.
Attachment #260785 -
Flags: review?(nrthomas)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 260785 [details] [diff] [review]
the fix
I don't really know enough about this code to review. Maybe bsmedberg ?
Attachment #260785 -
Flags: review?(nrthomas)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 260785 [details] [diff] [review]
the fix
Dan, do you mind reviewing this too? David is out the rest of the week. thanks!
Attachment #260785 -
Flags: superreview?(dveditz)
Attachment #260785 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 4•19 years ago
|
||
Comment on attachment 260785 [details] [diff] [review]
the fix
sr=dveditz
Attachment #260785 -
Flags: superreview?(dveditz) → superreview+
|
||
Comment 5•19 years ago
|
||
Comment on attachment 260785 [details] [diff] [review]
the fix
r=mkmelin+mozilla
Attachment #260785 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #260785 -
Flags: approval1.8.1.4?
|
|
Assignee | |
Comment 6•19 years ago
|
||
fixed on the trunk.
|
|
||
Comment 7•19 years ago
|
||
Comment on attachment 260785 [details] [diff] [review]
the fix
approved for 1.8.1.4, a=dveditz for release-drivers
Attachment #260785 -
Flags: approval1.8.1.4? → approval1.8.1.4+
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•19 years ago
|
||
verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007042703 - regxpcom.exe is not included in this buid -> adding verified keyword
Keywords: fixed1.8.1.4 → verified1.8.1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•