376690 - [regression] square list marker has incorrect size

Status: VERIFIED FIXED

(Core :: Layout: Block and Inline, defect, P3)

Description

[philippe (part-time)]

Attachment: test case

ul {list-style:square; font-size: .9em;}
This result in a list-marker that is sometimes square, sometimes smashed or stretched vertically

regressed between 20070206-11 and 20060207-02 --> bug 177805

Comment 1

[philippe (part-time)]

Attachment: screen shot

Comment 2

[Eli Friedman]

Hmm, looks like a pixel snapping bug; I can't reproduce it on Windows, though...

Comment 3

[hhh]

Confirming on Windows XP using the Minefield nightly from yesterday. Link to screenshot...
http://forums.mozillazine.org/viewtopic.php?p=2839746#2839746

Comment 4

[philippe (part-time)]

This is much better in some cases since the landing of bug 96041. When the line-height is set to normal (as is the testcase), the list-marker now displays correctly. 
But change the line-height (say, something like 1.5), the list-maker takes all kind of shapes, none looking like a square.

Comment 5

[philippe (part-time)]

Attachment: test case 2

Same test case as the first one, but with line-height:1.5 specified

Comment 7

[José Jeria]

From dupe: This can clearly be seen on the about:robots page.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We could fix this by snapping the size of the squares to the nearest pixel before drawing.  If we do this, we should center within the original non-snapped size, though.

(Note that for counters we use glyphs, though, so this wouldn't apply there.)

Comment 9

[j.j.]

Attachment: testcase 3

This fails on winXP, testcase 2 does not

Comment 10

[j.j.]

Attachment: testcase 3 (Windows)

Comment 11

[klonos]

still here on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090420 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090420041629

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This came up on css-d today; it's pretty simple to fix.

I figure centering is probably the best option, although I'm really not sure that it's the most likely to match what we're doing to text.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 426173 [details] [diff] [review]
patch

this probably wouldn't be hard to reftest

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

... or maybe it would

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/7b1c9ad46a36

Comment 17

[philippe (part-time)]

verified fixed with
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a2pre) Gecko/20100220 Minefield/3.7a2pre
@ rev/777fac9d915c