376877 - Investigate duplicate all-l10n.js packaging in windows installer

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We discovered that there are two all-1l0n.js files packaged into Windows installers for Thunderbird. If you use 7-zip to unpack a non en-US locale you find:

  nonlocalized/defaults/pref/all-l10n.js       with en-US settings
  localized/defaults/pref/all-l10n.js          with the actual locale settings

The NSIS installer copes just fine with this, as the localized file is copied in second, and the build works as expected. It did cause some problems with update verification during the release process for TB 2.0.0.0 RC1 (I'll file the workaround separately) and it seems like asking for trouble, so we should look at making a fix.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This matches Thunderbird's packages-static to what Firefox does with bin\defaults\pref in its packages-static:

Include all-l10.js in [@AB_CD] only and manually list the pref files in the base install. Thankfully we don't add/remove pref files very often.

I haven't tested this because I don't have a windows build environment at the moment, but I'm fairly sure it'll work.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 323058 [details] [diff] [review]
The fix

I don't have a windows build env set up either, so I can't test if it will work. Passing the review to david.

Comment 3

[David :Bienvenu]

I haven't had a lot of luck doing static builds, but I'll try again, and if it succeeds, try this patch.

Comment 4

[David :Bienvenu]

Comment on attachment 323058 [details] [diff] [review]
The fix

seems ok...

Comment 5

[Mark Banner (:standard8)]

Checked in, I'll download the installers later and check they are still ok.

Comment 6

[Mark Banner (:standard8)]

I've checked en-US and be installers from today and they both have just one copy of the file and install all defaults/pref files correctly. Therefore marking as fixed.

Nick, do we want this on the 1.8 branch? I guess the build system has worked around the problems that this was causing by now?

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I think it's nice-to-have but not necessary for build/release activities. You'd have to ask the 1.8 drivers if they would consider taking the change.

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #7)
> I think it's nice-to-have but not necessary for build/release activities. You'd
> have to ask the 1.8 drivers if they would consider taking the change.

I think as it is not necessary and the effect on the download size is minimal, we'll avoid possible chance of regression on the 1.8 branch and not nominate/take it (hopefully there will be no regressions anyway). TB 3 can then pick it up.